Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

reservedSeatTimeouts Memory Leak

See original GitHub issue

Issue Description

We encountered a suspecious memory leak when using this framework, the reservedSeatTimeouts of Room seems not release in some unkown reasons. The cpu% will grow slowly from 1 to much higher. We inspected the heap dump and found the reservedSeatTimeouts of room stored so many Timeout instances. See below screenshot: leak screenshot It seems in this function the this.reservedSeatTimeouts should delete the reservedSeatTimeout(delete this.reservedSeatTimeouts[sessionId]) when seats reservaltion expired.

Issue Analytics

State:
Created 3 years ago
Comments:5 (4 by maintainers)

Top GitHub Comments

1reaction

endelcommented, Dec 20, 2019

Hi guys, on version 0.11.25 I’ve pushed this change, which may fix the memory leak: https://github.com/colyseus/colyseus/commit/49f1c9641411c09a4c26489f7a0bb85950baba5e

Regarding the rooms not being disposed, I do have the same issue on production for some projects, and I don’t know exactly the reason yet. It never happens locally, so it’s difficult to reproduce and find how to fix. The @colyseus/monitor often displays one room with 0 clients, and when I click on “inspect”, there is one stale client in there.

0reactions

endelcommented, Oct 20, 2020

Closing as the original issue seems to have been resolved!