Server does not sync state with clients on the latest version

Steps to Reproduce

Example CodesSandbox: https://codesandbox.io/s/dazzling-mountain-hwzfxh

1. Open CodeSandbox
2. Preview of HTML shows client’s state (check console for more details).
3. Client sends ping message to server.
4. Server every 1s modifies the state.

Context

Server receives ping messages, but client is not updated with the latest state. Checked with DevTools, server is not sending any message (sends only two at the beginning, I think they are schema types related).

Adding @colyseus/monitor, and inspecting room’s state also shows empty state.

Your Environment

• Colyseus Version: 0.14.23, ws-transport 0.14.21, schema: 1.0.34
• Node.js Version: v14.8.1
• Link to your project: https://codesandbox.io/s/dazzling-mountain-hwzfxh

[jog1t]

It’s looks like TypeScript’s type decorator also does not work 😢. I’ve tried also using different versions, but without any luck. Here’s the same example from CodeSandbox, but uses ts-node or vite-node to run the server - https://github.com/jog1t/colyseus-issue-510.

🎉 What has worked for me is to define a schema class similar to this (see working-solution branch):

class State extends Schema {
  constructor() {
    super();
    this.property = "";
    this.number = 0;
  }
}

defineTypes(State, {
  property: "string",
  number: "number",
});

interface State extends Schema {
  property: string;
  number: number;
}

[WesleyClements]

This seems to only be a problem for TypeScript if you are compiling to ES2022/ESNext. Public instance fields are added to subclass instances using Object.defineProperty immediately after the super() call returns so the property defined in the Schema constructor is being overwritten. I don’t think there is an elegant solution to fix this currently. Could move the getters and setters definition to outside the constructor but that’s kind of wonky.