Race condition with `onAuth()` rejection

If the Colyseus server’s room throws a custom application error or returns false from onAuth(), the Colyseus Unity client sometimes hangs and gets no response.

eg. The below Unity client snippet sometimes never prints either of "Joined room successfully" or "Error joining room".

Client colyseusClient = new Client(COLYSEUS_URL);
Room<GameState> newColyseusRoom;
try {
  Debug.Log("Joining room...");
  newColyseusRoom = await colyseusClient.JoinOrCreate<GameState>("GameRoom", options);
  Debug.Log("Joined room successfully");
} catch (Exception e) {
  Debug.Log("Error joining room");
}

With the server snippet:

export default class GameRoom extends Room<GameState> {
  onAuth(_client: Client, _options: any): Promise<boolean> {
    return false;
  }
}

Colyseus Unity client version: 0.13.2
Colyseus Unity server version: 0.13.7

Possibly related:

• https://github.com/colyseus/colyseus-unity3d/pull/118
• https://github.com/colyseus/colyseus-unity3d/pull/119

[rnd256]

@endel I’ve verified that the current master branch resolves this issue: https://github.com/rnd256/minimal-colyseus/tree/onauth-rejection-race-condition-2020-10-11-master-branch

(I can’t comment about performance though, which is something you were worried about before)

[rnd256]

FYI I didn’t mean to indicate that I thought one of #118 and #119 was better than the other. #119 just happened to be the one I tested.

@endel unfortunately I’m not well-equipped to measure latency either (my game is not particularly latency-sensitive). Or were you just asking that I verify that the alpha branch fixes this bug?