question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Make the time from initial wheel touch alert to making noise longer

See original GitHub issue

I just took my first drive with 0.7.10 (since 0.7.7) tonight and since I don’t have DM at night I use wheel touch. However with the changes to wheel touch timings in this commit https://github.com/commaai/openpilot/commit/21d4ac1eebba06769f03edf7220ce84bd6ae154d I find myself not being able to catch the alert fast enough so that it doesn’t make noise. If I’m looking straight at the road, as soon as I notice that the alert to touch the wheel has shown, it’s just then turning to orange and starts making noise, possibly waking up anyone else in the car (but is also annoying if it’s just you).

Is there any way we can either delay this prompt noise, or revert part of that commit to make the time from initial “touch the wheel” alert to making noise alert its original length? It was perfect before, but now makes driving at night much more annoying. Another annoyance is the orange warning alert that makes noise turns on and off repeatedly if the monitoring model is uncertain, since the orange alert resets the hi_std_alert_enabled variable, so it’s just in a loop until I touch the wheel, even if I’m looking at the road and the model can see me.

That last thing could be solved by a timeout on how quickly it can show the uncertain alert after orange alert is shown.

Issue Analytics

  • State:closed
  • Created 3 years ago
  • Comments:13 (11 by maintainers)

github_iconTop GitHub Comments

1reaction
sshanecommented, Nov 3, 2020

Have any ideas what can be changed to fix the flickering?

1reaction
sshanecommented, Oct 31, 2020

I’ll go out and test the original values(/find ones that seem better) as well as try to fix that uncertain alert flickering while the orange “touch wheel” alert is on screen and open a PR for that

(Ah I see how that works now! 7-5=2 seconds for green prompt alert. Yeah that’s way too little, everyone I have try openpilot they don’t notice the screen quick enough for the older times yet alone 2 seconds lol)

Read more comments on GitHub >

github_iconTop Results From Across the Web

Adjust motor skills settings on Apple Watch
Ignore multiple touches: Turn on Ignore Repeat, then tap the plus or minus buttons to adjust the amount of time allowed between multiple...
Read more >
3 Most Common Brake Noises: Causes and How to Fix Them
Another common grinding noise from brakes happens when small pebbles get caught between the rotor and rotor backing plate, or when the backing ......
Read more >
Why is my car making noise when turning left? - Quora
Jack up the front of the car, one side at a time is OK. Grab the wheel top and bottom and see if...
Read more >
Understanding and Diagnosing Rear Differential Noise
Rear differential noise is often a result of lack of proper lubrication and misaligned gears. Learn all about rear differential noise here.
Read more >
What Is That Rubbing Steering Wheel Noise? - Protect My Car
Your steering wheel making a rubbing noise while driving is not normal, ... last for a long time, as under normal driving conditions,...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found