Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.
And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.
improve how ContentNotification handles its children
See original GitHub issueDescribe the bug
ContentNotification uses display:flex for its children and that sometimes desirable but could also creates issues in other cases where for example: when displaying 2 HTML text elements as one inline paragraph
Suggested solution
One solution that comes to mind immediately is to add support for display: block
Screenshots
This screenshot shows how the “customer support” link is being displayed with display: flex
This screenshot shows how the “customer support” link is being displayed when wrapping the 2 HTML elements in a container div (so the ContentNotification treat it as HTML element), so as you can see adding a wrapping container solves the issue but it might be helpful to have this handled by the uikit component itself. UiKit components should not enforce any layout on their children as I understand.
Issue Analytics
- State:
- Created 3 years ago
- Reactions:1
- Comments:7 (7 by maintainers)
Top Results From Across the Web
Top Related Medium Post
Top Related StackOverflow Question
Troubleshoot Live Code
Top Related Reddit Thread
Top Related Hackernoon Post
Top Related Tweet
Top Related Dev.to Post
Top Related Hashnode Post
Yes, I think so. Otherwise it can be re-opened. Sorry for not cleaning up.
I would have liked to alternate between
propssointlMessagedoes what we do now.childrengives control. Then the consumer can use anything (e.g. aSpacing).That would however be breaking I assume.
I wonder if anybody wants to current behaviour/layout?