Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

improve how ContentNotification handles its children

See original GitHub issue

Describe the bug ContentNotification uses display:flex for its children and that sometimes desirable but could also creates issues in other cases where for example: when displaying 2 HTML text elements as one inline paragraph

Suggested solution One solution that comes to mind immediately is to add support for display: block

Screenshots This screenshot shows how the “customer support” link is being displayed with display: flex image

This screenshot shows how the “customer support” link is being displayed when wrapping the 2 HTML elements in a container div (so the ContentNotification treat it as HTML element), so as you can see adding a wrapping container solves the issue but it might be helpful to have this handled by the uikit component itself. UiKit components should not enforce any layout on their children as I understand. image

Issue Analytics

  • State:closed
  • Created 3 years ago
  • Reactions:1
  • Comments:7 (7 by maintainers)

github_iconTop GitHub Comments

tdeekenscommented, Aug 25, 2020

Yes, I think so. Otherwise it can be re-opened. Sorry for not cleaning up.

tdeekenscommented, Aug 12, 2020

I would have liked to alternate between props so intlMessage does what we do now. children gives control. Then the consumer can use anything (e.g. a Spacing).

That would however be breaking I assume.

I wonder if anybody wants to current behaviour/layout?

Read more comments on GitHub >

github_iconTop Results From Across the Web

Pay attention to distraction » Nieman Journalism Lab
Not an easy landscape in which to build traffic, increase attention time, and develop loyalty, and my hat is off to those fighting...
Read more >
Ethics, Service, and Professionalism Programs | WMU Cooley ...
WMU-Cooley encourages programming with local public schools, to improve the education of all and to interest students in continuing their education and even ......
Read more >
A Mobile Platform for Teaching Nonverbal Social ... - MD-SOAR
The purpose of this project is to provide a mobile platform for teaching nonverbal social communication skills to high-functioning autistic children.
Read more >
Got vs. gotten - PaperRater
Smith, King, & Hoyte (2014) examined the learning outcomes of using bodily movement to teach children about angles with twenty third grade children....
Read more >
Chapter 2 | Defense Security Cooperation Agency
SCOs work with the partner nation to develop a combined EUM control plan that spells ... age of any children, and any other...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Post

No results found

github_iconTop Related Hashnode Post

No results found