Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Q: typography styles

See original GitHub issue

As I was playing around with ui-kit being used with e.g. Gatsby/Next.js, I noticed that the Text components use kind of “global styles”, even though the styles are defined in the css file.

https://github.com/commercetools/ui-kit/blob/d1acba93d97419f8a85db51471edf602087515fa/src/components/typography/text/text.mod.css#L15-L70

I’m wondering about a couple of things:

should we really target html tags instead of using specific classes?
if we do want to have it like this, we should maybe move those selectors to our e.g. reset.mod.css

Thoughts?

Issue Analytics

State:
Created 5 years ago
Reactions:1
Comments:10 (10 by maintainers)

Top GitHub Comments

1reaction

montezumecommented, Jan 3, 2019

FYI I’m working on this now

1reaction

dferber90commented, Jan 3, 2019

The goal I had for ui-kit is to be able to drop it into any page while having the ui-kit elements styled correctly - and also without having ui-kit overwrite any other styles on that page. So ui-kit should not define any global styles.

Top Results From Across the Web

120 Best Q ideas | typography, lettering, typography design

Oct 7, 2019 - Explore Letter Kit's board "Q", followed by 3844 people on Pinterest. See more ideas about typography, lettering, typography design....

Free fonts Letter Q - Urban Fonts

You can customize your experience with live font previews. All fonts are categorized and can be saved for quick reference and comparison.

Q - Wikipedia

Uppercase "Q" All three styles are considered equally valid, with most serif typefaces having a Q with a tail that meets the circle,...

The Letter Q - Fonts.com

This opportunity for typographic playfulness may even date back to the Phoenicians: the original ancestor of our Q was called “ooph,” the Phoenician...

File:Q typographic styles.svg - Wikimedia Commons

English: Typographic styles of the capital letter "Q". Where possible, fonts were chosen from File:Latin alphabet Qq.svg for the purposes of ...