Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Issue Description

A patch version of redbox-react was published an hour ago but the peer dependency was changed to only support React 15.

Our CI is now failing with:

error   17-Jun-2016 16:17:59    npm ERR! peerinvalid The package react@0.14.8 does not satisfy its siblings' peerDependencies requirements!
error   17-Jun-2016 16:17:59    npm ERR! peerinvalid Peer redbox-react@1.2.7 wants react@^15.0.0

Can we change this to a major version bump? Dropping support for React 0.14 is a breaking change. It would be good if we could get a patch version on the v1 branch which is just an old version which supports React 0.14 so that we don’t break compatibility for other users.


Issue Analytics

  • State:closed
  • Created 7 years ago
  • Comments:11 (6 by maintainers)

github_iconTop GitHub Comments

davidpfahlercommented, Jun 17, 2016

Dear all, I’m sorry for breaking your builds. I decided to release a new fix version (=minor) that reenables support for react 0.14. Your broken builds should automatically unbreak this way. Please let me know what you think about this and if your builds are OK now.

davidpfahlercommented, Jun 17, 2016

Sorry for this breaking change! This one slipped through the cracks. Unfortunately, also no one besides me caught it on the PR. I will try to fix this as soon as I’m back at my computer.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Semantic Versioning 2.0.0 | Semantic Versioning
As soon as you realize that you've broken the Semantic Versioning spec, fix the problem and release a new minor version that corrects...
Read more >
building5/you-broke-semver-now-what: Step by step ... - GitHub
The purpose of this document is to help you calmly and methodically figure out the best course of action to take when you...
Read more >
Major Version Numbers are Not Sacred - Tom Preston-Werner
This can be hard, though, especially when it comes to breaking changes. In the time before Semantic Versioning, major version number changes ...
Read more >
Official NPM registry accepts broken semver. Latest version: 0.44.1-alpha.10, last published: 3 years ago. Start using npm-broken-semver in ...
Read more >
Why I don't like SemVer anymore - Tall, Snarky Canadian
To me that speaks volumes to why SemVer does not inherently work: someone's bugfix may be someone else's breaking change.
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Post

No results found

github_iconTop Related Hashnode Post

No results found