Fix `new Buffer` deprecation warning by updating dependency

Right now, it seems this project uses a very old version of inquirer. What would it take to upgrade that? The main reason I care is because this seems to be blocking resolution of an annoying deprecation warning when using yarn with Node >= 10 because it uses commitizen#inquirer#external-editor#chardet (v0.4.2, which uses new Buffer(...) – v0.7.0 updates to Buffer.alloc(...), but it’s not getting used because here inquirer is pinned to 1.2.3).

It looks like these are the breaking changes between 1.x and 6.x:

• 2.x: Drop support for node 0.10 and 0.12
• 3.x: Drop support for Node < 4
• 4.x: The core codebase went through a major es5 to 6 refactor. As such, we’re dropping support for Node 4. This change will likely require changes to the community Plugins as es6 classes are enforcing more restriction (like constructor can only be invoked with new)."
• 5.x: Upgrade to RxJS v5 which updates a bunch of Reactive interface method names. For people not using the Reactive interface directly, this new major release should just work out of the box.
• 6.x: Update to Rx.js v6

[karlhorky]

In case you want to go ahead with the upgrade after all, I recently upgraded Inquirer.js from version 3 to 6 in inquirer-autocomplete-prompt. I tried to make the commits as granular as possible.

Maybe the pull request is good reference:

https://github.com/mokkabonna/inquirer-autocomplete-prompt/pull/64

[jimthedev]

I think it’s time for us to release a new 2.x version with some deprecation warnings about specific items. Then 3.x will just be a bigger breaking change release than we’d anticipated. IMO it is worth it at this point.

– Jim ForCy

On August 20, 2018 at 6:27:19 AM, Linus Unnebäck ([e-mail]) wrote:

We could probably go to 3.x without problem, unfortunately going beyond that would be a breaking change from our side.

That being said, us passing inquirer to the adapter is deprecated, so we could probably create a breaking change that removes it 🙌

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/commitizen/cz-cli/issues/552#issuecomment-414284044, or mute the thread https://github.com/notifications/unsubscribe-auth/AAGpiqplZGfITce-fcv4zuUZjWaXPIc6ks5uSp0XgaJpZM4WC7Va .