question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

"improvement" offered as an option but not in enum

See original GitHub issue

When using git cz, one option for a type to select is “improvement”, but this fails the enum check


husky > commit-msg hook failed (add --no-verify to bypass)
git exited with error code 1
kris@Kriss-MacBook-Pro cent-admin % git cz
cz-cli@4.0.3, cz-conventional-changelog@3.0.1

? Select the type of change that you're committing: 
  revert:      Reverts a previous commit 
  feat:        A new feature 
  fix:         A bug fix 
❯ improvement: An improvement to a current feature 
  docs:        Documentation only changes 



⧗   input: improvement(employers): added new subscriptions
✖   type must be one of [build, chore, ci, docs, feat, fix, perf, refactor, revert, style, test] [type-enum]

✖   found 1 problems, 0 warnings
ⓘ   Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint

Issue Analytics

  • State:open
  • Created 4 years ago
  • Reactions:2
  • Comments:5 (1 by maintainers)

github_iconTop GitHub Comments

3reactions
AndersDJohnsoncommented, Nov 3, 2019

@OmgImAlexis @ktwbc @jimthedev It looks like they removed improvement as recommended. It was in their 1.0.0-beta.4 release, but removed in 1.0.0.

I’m proposing we consider removing it in https://github.com/commitizen/conventional-commit-types/pull/16, so I would appreciate if you could share thoughts there.

1reaction
OmgImAlexiscommented, Oct 21, 2019

@jimthedev since https://github.com/conventional-changelog/commitlint/pull/832 has been merged can we get config-conventional’s version bumped please.

Read more comments on GitHub >

github_iconTop Results From Across the Web

java - What's the best way to implement `next` and `previous ...
Try this: public enum A { X, Y, Z; private static final A[] vals = values(); public A next() { return vals[(this.ordinal() +...
Read more >
Enum Types - Java™ Tutorials
An enum type is a special data type that enables for a variable to be a set of predefined constants. The variable must...
Read more >
Persisting Enums in JPA - Baeldung
In JPA version 2.0 and below, there's no convenient way to map Enum values to a database column. Each option has its limitations...
Read more >
PHP 8.1: Enums
The UnitEnum::cases method returns an array of all cases of a given Enum. PHP classes are not allowed to implement this interface, and...
Read more >
Enum classes | Kotlin Documentation
The valueOf() method throws an IllegalArgumentException if the specified name does not match any of the enum constants defined in the class. You...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found