precommit runs twice when using husky

Here’s my relevant package.json:

"devDependencies": {
    "commitizen": "^2.9.6",
    "cz-conventional-changelog": "^2.0.0",
    "husky": "^0.13.2",
    "lint-staged": "^3.4.0",
    "prettier": "^1.2.2"
},
"scripts": {
   "precommit": "lint-staged --verbose",
   "commit": "git-cz",
},
"lint-staged": {
    "*.js": [
      "prettier --single-quote --semi=false --write",
      "git add"
    ]
},
"config": {
    "commitizen": {
      "path": "./node_modules/cz-conventional-changelog"
    }
},

lint-staged is correctly called once before the commitizen command line form appears, and then incorrectly husky - npm run -s precommit is run after. Typically without commitizen only lint-staged is called. Somehow commitizen is triggering husky to be called. No where do I have this script: npm run -s precommit. It seems commitizen somehow triggers it after you complete the form.

[jimthedev]

That is a bug in husky that happens due to a “feature” of npm-scripts that auto run scripts with the name prexxx where xxx is the name of another script. So, because you’re using commit and precommit it is running them twice.

Until husky fixes this you can simply change your commitizen task to cmt or something else (cz, co, etc).

We could probably update our docs to reflect that when using commitizen and husky you should pick another name than npm run commit. Want to put in a PR?

[faceyspacey]

nice find!

Here’s the PR as requested: https://github.com/commitizen/cz-cli/pull/433