question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

[Bug] Bump commits ALL files

See original GitHub issue

Description

Instead of committing just all files containing a version ALL changed files are committed (new ones are not just changed ones). This is not good if a change is not meant to be included in the release.

While this can be avoided by branching it should still behave different as git add . and git commit <whatever> is very carelessly.

Steps to reproduce

  1. Create repo and add cz config file
  2. Add file1.txt and file2.txt
  3. stage and Commit file1
  4. cz bump (Behaves as expected)
  5. Commit the adding of file2
  6. Change the content of file1 and don’t stage it
  7. cz bump

You will see that all changes of file1 are commited in the bump: 0.0.1 -> 0.0.2 commit

Desired behavior

When executing a cz bump

  1. Stash the changes and added files (staged and unstaged the same)
  2. Warn the user if he has Staged files because they will be merged with the unstaged ones when stashing
  3. Execute the bump
  4. Pop the stash
  5. Delete the stash

Environment

  • commitizen version:2.13.0

  • python version:Python 2.7.17

  • operating system:Linux

Issue Analytics

  • State:open
  • Created 3 years ago
  • Reactions:2
  • Comments:5 (3 by maintainers)

github_iconTop GitHub Comments

1reaction
woilecommented, Mar 5, 2021

I’m in as a positional argument as well. I’d like to see an implementation 👍🏻

1reaction
Lee-Wcommented, Feb 20, 2021

The “auto stashing” option sounds good to me as long as we do not set it as the default behavior. If we’d like to do so in the future, we’ll need to bump a major version

Read more comments on GitHub >

github_iconTop Results From Across the Web

Version Bump Prompt - JavaScript Dev Tools
Interactive CLI that bumps your version numbers and more. ... -a, --all Commit/tag/push ALL pending files, not just the ones that were bumped....
Read more >
Git - Bioconductor
Checks and version bumps. Each commit pushed to the Bioconductor repository should build and check without errors or warnings BiocGenerics$ cd .. R...
Read more >
conventional commit messaging
fix: a commit of the type fix patches a bug in your codebase (this correlates ... e.g., a fix: , feat: & chore:...
Read more >
Generating changelog automatically with Standard Version
The “fix” type indicates that this commit removes a bug in the codebase. Creating a release with such a commit results in bumping...
Read more >
Automated Releases - Melos
Conventional Commits. Currently the following commit types trigger a version bump: docs - A documentation change. feat - A new feature. fix -...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found