[test] Update commit messages in test cases
See original GitHub issueGoal make unit tests more accurate
Description
In tests/commands/test_bump_command.py#L23, the message is feat: msg
which should be feat(scope): msg
. There might be some cases like it.
Issue Analytics
- State:
- Created 4 years ago
- Comments:6 (6 by maintainers)
Top Results From Across the Web
semantic commit message type for adding unit testing [closed]
Question : what semantic commit message type should i use for adding unit test cases? like Udin.test.js , feat , chore , or...
Read more >How to write good commit messages in Git - Tools QA
It is the same as when writing the test cases. The test cases ... A meaningful commit message describes the change that you...
Read more >How to structure commits when unit test requires refactoring
I can refactor to make unit testing possible, but it results in a very large code change touching many other non-test classes that...
Read more >Semantic Commit Messages - GitHub Gist
See how a minor change to your commit message style can make you a better programmer. ... +-------> Type: chore, docs, feat, fix,...
Read more >Do your commits pass this simple test? - DEV Community
I've found Git commit messages are oftentimes more useful than code comments. Can you describe your change verbosely, yet concisely?
Read more >Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start FreeTop Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Top GitHub Comments
I got it! Thank you for your quick reply. I’ll make a draft PR soon and we could have a discuss on the codes there.
Yes, go ahead please.
So basically the idea is to try to diversify ours tests a bit more, in this particular case is to have some examples with scope and some others without scope. In case it’s not clear the scope is the part that goes between the parenthesis:
users
would be the scope.Keep in mind, (AFAIK) that nor @Lee-W , nor me have checked if the tests are already diversified haha. But if you start reading the tests, and there are enough tests with scope and enough without, then this ticket could be closed 👍
It could be consider an investigation on our source code 💪
Good luck!