question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

[test] Update commit messages in test cases

See original GitHub issue

Goal make unit tests more accurate

Description In tests/commands/test_bump_command.py#L23, the message is feat: msg which should be feat(scope): msg. There might be some cases like it.

Issue Analytics

  • State:closed
  • Created 4 years ago
  • Comments:6 (6 by maintainers)

github_iconTop GitHub Comments

1reaction
josixcommented, Aug 6, 2020

I got it! Thank you for your quick reply. I’ll make a draft PR soon and we could have a discuss on the codes there.

1reaction
woilecommented, Aug 6, 2020

Yes, go ahead please.

So basically the idea is to try to diversify ours tests a bit more, in this particular case is to have some examples with scope and some others without scope. In case it’s not clear the scope is the part that goes between the parenthesis:

feat(users): add full name

users would be the scope.

Keep in mind, (AFAIK) that nor @Lee-W , nor me have checked if the tests are already diversified haha. But if you start reading the tests, and there are enough tests with scope and enough without, then this ticket could be closed 👍

It could be consider an investigation on our source code 💪

Good luck!

Read more comments on GitHub >

github_iconTop Results From Across the Web

semantic commit message type for adding unit testing [closed]
Question : what semantic commit message type should i use for adding unit test cases? like Udin.test.js , feat , chore , or...
Read more >
How to write good commit messages in Git - Tools QA
It is the same as when writing the test cases. The test cases ... A meaningful commit message describes the change that you...
Read more >
How to structure commits when unit test requires refactoring
I can refactor to make unit testing possible, but it results in a very large code change touching many other non-test classes that...
Read more >
Semantic Commit Messages - GitHub Gist
See how a minor change to your commit message style can make you a better programmer. ... +-------> Type: chore, docs, feat, fix,...
Read more >
Do your commits pass this simple test? - DEV Community ‍ ‍
I've found Git commit messages are oftentimes more useful than code comments. Can you describe your change verbosely, yet concisely?
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found