Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Add codestyle to git

See original GitHub issue

Summary:

The codestyle should be a part of the project and require no setup for a new contributor

Steps to reproduce:

Clone the project and go to a file, press ctrl+alt+l and see the file will be changed.

Would you like to work on the issue?

I think this would be best if somebody with an already correct style configured were to do this.

Just adding this to the .gitignore should be sufficient

# IDEA/Android Studio Ignore exceptions
!/.idea/inspectionProfiles/
!/.idea/codeStyles/

Issue Analytics

State:
Created 4 years ago
Comments:7 (2 by maintainers)

Top GitHub Comments

1reaction

macgillscommented, Mar 12, 2020

Just for clarification, who do you refer to as “people” here? Contributors?

Contributors, frogmen, mermaids, skeletor, whoever can submit a pr to this repo.

If a file is in git then it can be changed and trying to enshrine it seems like something we should not do. Just treat it like any other file and educate people on IntelliJ/Android Studio functionality.

I have a local branch for the documentation update and am awaiting access to the repo.

0reactions

sivaraamcommented, Mar 12, 2020

@sivaraam looks like the user resolved it.

@macgills Yeah, he has.

A part of having our codestyle in git is that people can change it if they so wish, …

Just for clarification, who do you refer to as “people” here? Contributors?

… we should just reject anything done accidentally.

To clarify, I’m not against keep the code style in Git. I was just wondering if we could avoid such accidental changes while keeping the file Git. 🤔

The closest I could find is https://stackoverflow.com/a/936290/5614968 (the git update-index --assume-unchange part). But that’s in the hands of the contributors. Not sure if there are any better ways.

I was going to make a documentation update, I asked a question somewhere about whether the issue should be here or on the documentation repo. I’ll just go do it on the doc repo

Yeah, the wiki has been moved to the documentation repo. So, that would be right place. 🙂