Current issues with direct Nearby uploads

Summary:

I thought we should probably keep a list of issues we are experiencing with the directNearbyUploadsNew feature branch, so we don’t miss anything out before releasing to production. Please feel free to edit this post to add issues or detail for issues.

Steps to reproduce:

Build from 2.7.x-release and test the Nearby feature

• 1. Memory leaks PR #1390
• 2. Crash when loading map (by the time I finished typing this out, I had lost the logcat. Sorry. 😕 Will post when I encounter it again).
• 3. Text wrap issues in bottom sheet (see SS below). I would recommend removing “Directions” text
• 4. Fix “?” description bug in map (see SS below). This has already been fixed in list, we just need to copy the fix over to map. I should be able to do it after I’m done with my category PR.
• 5. Crash on orientation change crashes when list view is open and orinetation changed. PR: #1385
• 6. Bug: if you click one of nearby markers and make information bottom sheet visible, then go to settings and change theme, app will crash when you re-start nearby activity. Log is at below comment PR #1391
• 7. Action bar is hidden
• 8. Fix current location point visibility when bottom sheet is expanded, and re-center button is clicked. PR: #1381
• 9. Fix transparent view is top of menu bar - PR is ready waiting for review #1378

[neslihanturan]

@97balakrishnan after you saw that I was working on the internet thing and said “ok” , why did you create a related PR? We are not racing, we are colobrating please consider the comments next time…

[neslihanturan]

Thanks for your reports @97balakrishnan