Custom author name not reflecting in summary

Summary:

Custom author name preference should reflect the text value change in the summary, instead of repeating the information in the summary of Use custom author name switch preference.

Steps to reproduce:

How can we reproduce the issue?

Go to Settings and enable the Use custom author name. Change the name by tapping on the Custom author name preference.

What did you expect the app to do, and what did you see instead?

I expected the current custom name to be reflected in the summary of that preference. However, the summary is fixed redundant information. I say redundant because we have already conveyed the meaning of the preference to the user.

Device and Android version:

Redmi Note 5 Pro MIUI version 11 Android 9

Commons app version:

master and betaDebug

Screen-shots:

Changing Custom author name preference

After tapping OK

Would you like to work on the issue?

Yes. If we can agree that the issue is genuine, then I’d love to start working on it.

[gupta-anmol]

Yeah, disabling a toggle would indeed be better. I suppose we should just keep the two option as it is then. That would be a lot better, IMO.

I agree with @sivaraam, the toggle will perhaps become unintuitive if it would do more than just toggling. I have rarely seen the toggle doing more. For example, in the official Reddit app, there’s an option to toggle the dark mode and a separate option to choose the dark mode theme. This is similar to our issue. I can imagine it getting slightly annoying if the app asked me my dark theme preference every time I turned on dark mode.

[ashishkumar468]

Personally I think, a toggle would be simpler in terms of UX, disabling the author name by a switch surely seems better than making the user manually clear it.