question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Migrate all APIs to retrofit

See original GitHub issue

Summary:

This is a subtask to track network layer refactoring as part of #1092.

  • getAuthCookie > PR raised
  • login > PR raised
  • getEditToken > PR raised
  • getWikidataCsrfToken > PR raised
  • getCentralAuthToken > PR raised
  • fileExistsWithName
  • pageExists
  • findThumbnailByFilename
  • getCategoryImages
  • getSubCategoryList
  • getParentCategoryList
  • searchCategory
  • uploadFile > PR raised
  • edit > PR raised
  • prependEdit > PR raised
  • appendEdit > PR raised
  • wikidatCreateClaim > PR raised
  • addWikidataEditTag > PR raised
  • fetchMediaByFilename
  • searchCategories
  • allCategories
  • getNotifications
  • markNotificationAsRead > PR raised
  • searchTitles
  • revisionsByFilename
  • existingFile
  • logEvents
  • isUserBlockedFromCommons

Suggested test flows (by misaochan) for backend-overhaul branch:

  • Log in, upload a picture. Make sure the upload does not fail and that it is associated with the correct account (check this in Commons). Log out, then log in to a different account. Repeat the process. Log out, then log back in to the original account. Repeat the process for the last time.
  • Test with 2FA account if you have one
  • Try uploading a file that already exists or a title that already exists
  • Test notifications
  • Test Achievements
  • (After Vivek reports this is fixed): Test Wikidata edits from Nearby

Issue Analytics

  • State:closed
  • Created 4 years ago
  • Reactions:6
  • Comments:35 (17 by maintainers)

github_iconTop GitHub Comments

3reactions
ilgazercommented, Sep 19, 2019

Wrong dates: Dates appear to be using the upload date again instead of the date taken - the picture above was taken on 15 Jul

IMO we should rewrite FileProcessor and the weird code surrounding it. That will probably also resolve this bug. I’ve started working on it.

2reactions
maskaravivekcommented, Nov 23, 2019

All the items in this task have now been completed. Closing this issue now. 😃

Thank you, everyone, for your contributions. 😃

Read more comments on GitHub >

github_iconTop Results From Across the Web

Migrating to Retrofit 2.0 from Volley | by Dandré Allison | Medium
This article will demonstrate changes we made to migrate to Retrofit, ... There are two ways to handle instantiating all of these API...
Read more >
Migrate applications from using API v2 to API v3 - etcd
Migrating an application from the API v2 to the API v3 involves two steps: 1) migrate the client library and, 2) migrate the...
Read more >
Migrate API overview - Drupal
The Migrate API provides services for migrating data from different sources to Drupal 8.
Read more >
Migrating APIs to Different Environments
This allows you to import and export APIs between your environments. ... You can use the below command to export all the APIs...
Read more >
When Retrofit will be migrating to okhttp 4.x APIs · Issue #3566
What conflict? 4.x and 3.x are meant to be binary compatible. All reactions.
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found