Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Use the primaryLightColor for dark theme in the app

See original GitHub issue

There’s a color specified in colors.xml with the name primaryLightColor. It looks like a nice complement to the primaryColor. While primaryColor seems suited for light theme, the light variant seems suited for the dark theme of the app.

So, I suggest using it in place of primaryColor for the dark theme. As a matter of fact, we could even consider using it for the icons in the bottom bar of the new UI. The current black-on-blackish has poor contrast.

Issue Analytics

State:
Created 3 years ago
Reactions:1
Comments:5 (2 by maintainers)

Top GitHub Comments

2reactions

misaochancommented, Dec 11, 2020

The screenshot on the right looks better indeed to me. 😃

(Also it seems the author names are completely hidden in dark mode, you can just see a tiny sliver of the “person” icon on the left, and you can’t see the text at all.)

2reactions

nicolas-raoulcommented, Dec 11, 2020

@sivaraam is right, at first better work on more well-defined issues rather than spend time implementing many details for possibly nothing.

Additionally, at first please focus on bugs as explained at https://github.com/commons-app/commons-app-documentation/blob/master/android/Volunteers-welcome!.md . Here is a URL that gives bugs that are great for newcomers to work on: https://github.com/commons-app/apps-android-commons/issues?utf8=✓&q=is%3Aopen+is%3Aissue+no%3Aassignee+-label%3Aassigned+-label%3Adebated+label%3Abug

Anyway, feel free to push your code to a branch of your repository and post a link here, that might help someone in the future 😃 Thanks a lot for your enthusiasm, and welcome to the team!