Split FunctionApp & WebApp
See original GitHub issueI am trying to create support for selecting runtime stack for WebApp
, but now in code the function for creating ArmTemplate
record considers functionApp as another “version” of WebApp. The problem is, that even if they are close together, they do not offer exactly the same options for setup.
FunctionApp:
WebApp:
Also each template writes Runtime Stack
in slightly different way.
FunctionApp:
"appSettings": [
{
"name": "FUNCTIONS_WORKER_RUNTIME",
"value": "dotnet"
}
WebApp:
"appSettings": ... omited
"metadata": [
{
"name": "CURRENT_STACK",
"value": "dotnetcore"
}],
This would force me to do another if
logic in writer logic (where anonymous record would differ based on whether Kind
contains functionApp
or not), which doesn’t sound too clean to me. Also thinking about adding another options like always_on
, which is not available in FunctionApp template, the if
would appear more than once.
Proposal: Add FunctionApp as another SupportedResource
case (even if it is neeearly same as WebApp) and also add different Runtime stack values for each type as it is now in Azure Portal.
Good idea, wrong idea, total nonsense? What do you think @isaacabraham?
Issue Analytics
- State:
- Created 4 years ago
- Comments:7 (7 by maintainers)
Top GitHub Comments
I know what you mean… I’ll try keep the current structure first (and add new DU for runtime stack) and we will see. It is fresh meat so we can still easily refactor later.
Reopening - we can close this issue as part of the PR acceptance process 😃