[bug] bazel generator not usable for packages with multiple libs, like openssl

Environment Details

• Operating System+version: All
• Compiler+version: Not relevant
• Conan version: All
• Python version: All

Steps to reproduce

Use the bazel generator and use libcurl on Linux in your project, so it depends on openssl. libcurl will not be usable in your bazel project, since libcrypto.a and libssl.a appear in the wrong order for the linker

Solution

To make the order work, the alwayslink = True attribute should be set on the cc_import libs

So this:

cc_import(
    name = "ssl_precompiled",
    static_library = "lib/libssl.a",
)

cc_import(
    name = "crypto_precompiled",
    static_library = "lib/libcrypto.a",
)

should look like that

cc_import(
    name = "ssl_precompiled",
    static_library = "lib/libssl.a",
    alwayslink = True,
)

cc_import(
    name = "crypto_precompiled",
    static_library = "lib/libcrypto.a",
    alwayslink = True,
)

in the generated BUILD file for openssl

we can also discuss if it would not make sense to set visibility = ["//visibility:public"], on the cc_import part, since there are use cases where users use only libcrypto , but not libssl from openssl, but that might be a different issue

[czoido]

yes, the #do not sort on the right position does prevent buildifier from sorting array entries I updated the PR

Great, I’ll mark this for the next release. Thanks for the contribution.

[a4z]

yes, the #do not sort on the right position does prevent buildifier from sorting array entries I updated the PR