[bug] Compatible cached packages not resolved correctly

Environment Details (include every applicable attribute)

• Operating System+version: Windows 10 64
• Compiler+version: VS 2019 16
• Conan version: 1.41.0
• Python version: 3.8.8
• Revisions enabled: True

Steps to reproduce (Include if Applicable)

• Assume packages A, B, C, D and two build settings Settings1 and Settings2 resulting in different package ids.
• B requires A
• C requires A
• D requires both B and C
• A, B and C have been built with Settings1 and each override package_id to provide a compatible package for Settings2.
• D needs to be built with Settings2

If you call conan install on D with Settings2 we observer the following:

• A, B and C are reported as missing but a compatible package has been found: A/1.0@user/channel: Main binary package 'f278b6f5a018dfdaf3f1aaf111c91b35b8dbeec5' missing. Using compatible package 'f85619e3f4a4d53fb5b48d3c40437fc2f08c69e6' B/1.0@user/channel: Main binary package 'f278b6f5a018dfdaf3f1aaf111c91b35b8dbeec5' missing. Using compatible package 'f85619e3f4a4d53fb5b48d3c40437fc2f08c69e6' C/1.0@user/channel: Main binary package 'f278b6f5a018dfdaf3f1aaf111c91b35b8dbeec5' missing. Using compatible package 'f85619e3f4a4d53fb5b48d3c40437fc2f08c69e6'
• A might end up multiple times within the self.info.requires dict used in the package_id methods of B and C due to different package ids which leads to wrong hashes being created.
• If we workaround the previous issue by throwing out the multiple occurrances of the same package requires within package_id, the wrong package binary is finally used for A: File "c:\programdata\anaconda3\lib\site-packages\conans\client\installer.py", line 560, in _handle_node_cache assert os.path.isdir(package_folder), ("Package '%s' folder must exist: %s\n" AssertionError: Package 'A/1.0@user/channel:f278b6f5a018dfdaf3f1aaf111c91b35b8dbeec5' folder must exist: C:\.conan\3785e5\1

Perhaps this might be related to #9446

Possible Fix ?

• From debugging we found that there exist two nodes in the conan graph for package A, which originally point to the same package id.
• For the first node A _evalute_node from file graph_binaries.py is called and compatible packages are computed. Then, the _package_id of that node is set to the compatible package id f85619... and the node.binary is set to cached mode.
• For the second node A _evaluate_is_cached in the same file encounters the first node A (previous_nodes) and sets its binary also cached as well. However, the _package_id is not modified.

If we set the _package_id to the previous_node everything works fine but we are not sure if this has any unwanted side effects: node._package_id = previous_node._package_id

I hope that this helps in resolving the bug.

[burgerkiller79]

I’m glad I was able to contribute something. I don’t necessarily have to submit the PR, especially since you already did it, but thanks for the offer.

[memsharded]

Great, I have been able to reproduce with your test changes too.

Also reviewed your fix, it is indeed looking good, exactly in the spot, great job. Thanks for all the work. I have submitted PR #10266 for 1.45, but if you want to submit it yourself to become official contributor, you totally deserve it, just let me know and I will close my PR.

This will be naturally merged to develop2 branch too, lets try to make sure that this continue to work in 2.0 (except a new way to define visibility will be introduced).