[libpng] libpng/1.6.38: Regression (does not build anymore on Clang for Windows)

Description

libpng/1.6.37 was building fine with our Clang/Windows Conan profile. 1.6.38 does not build anymore, with an error during _patch_source().

ERROR: libpng/1.6.38: Error in build() method, line 166
        self._patch_source()
while calling '_patch_source', line 108
        replace_in_file(self, os.path.join(self.source_folder, "CMakeLists.txt"),
        ConanException: replace_in_file didn't find pattern 'COMMAND "${CMAKE_COMMAND}" -E copy_if_different $<TARGET_LINKER_FILE_NAME:${S_TARGET}> $<TARGET_LINKER_FILE_DIR:${S_TARGET}>/${DEST_FILE}' in 'C:\Users\adn\.conan\data\libpng\1.6.38\_\_\build\1c035d0350b06e767d064f73457b0db056f51647\src\CMakeLists.txt' file.

Package and Environment Details

• Package Name/Version: libpng/1.6.38
• Operating System+version: Windows 10
• Compiler+version: Clang 15 (scoop install llvm)
• Conan version: conan 1.53.0

Conan profile

[settings] arch=x86_64 arch_build=x86_64 build_type=Debug compiler=clang compiler.cppstd=20 compiler.version=15 os=Windows os_build=Windows [options] [build_requires] *: cmake/3.24.1 [env] CONAN_CMAKE_GENERATOR=Unix Makefiles [conf] tools.cmake.cmaketoolchain:generator=Unix Makefiles

Steps to reproduce

conan install -pr:h clang15-win-dev libpng/1.6.38@ --build=libpng

Logs

Click to expand log

libpng/1.6.38: Applying build-requirement: cmake/3.24.1
libpng/1.6.38: WARN: Build folder is dirty, removing it: C:\Users\adn\.conan\data\libpng\1.6.38\_\_\build\1c035d0350b06e767d064f73457b0db056f51647
libpng/1.6.38: Copying sources to build folder
libpng/1.6.38: Building your package in C:\Users\adn\.conan\data\libpng\1.6.38\_\_\build\1c035d0350b06e767d064f73457b0db056f51647
libpng/1.6.38: Generator txt created conanbuildinfo.txt
libpng/1.6.38: Calling generate()
libpng/1.6.38: WARN: Using the new toolchains and generators without specifying a build profile (e.g: -pr:b=default) is discouraged and might cause failures and unexpected behavior
libpng/1.6.38: Preset 'debug' added to CMakePresets.json. Invoke it manually using 'cmake --preset debug'
libpng/1.6.38: If your CMake version is not compatible with CMakePresets (<3.19) call cmake like: 'cmake <path> -G "Unix Makefiles" -DCMAKE_TOOLCHAIN_FILE=C:\Users\adn\.conan\data\libpng\1.6.38\_\_\build\1c035d0350b06e767d064f73457b0db056f51647\build\generators\conan_toolchain.cmake -DCMAKE_MACOSX_BUNDLE=OFF -DCMAKE_POLICY_DEFAULT_CMP0091=NEW -DCMAKE_BUILD_TYPE=Debug'
libpng/1.6.38: WARN: Using the new toolchains and generators without specifying a build profile (e.g: -pr:b=default) is discouraged and might cause failures and unexpected behavior
libpng/1.6.38: Aggregating env generators
libpng/1.6.38: Calling build()
libpng/1.6.38: apply_conandata_patches(): No patches defined in conandata
libpng/1.6.38:
libpng/1.6.38: ERROR: Package '1c035d0350b06e767d064f73457b0db056f51647' build failed
libpng/1.6.38: WARN: Build folder C:\Users\adn\.conan\data\libpng\1.6.38\_\_\build\1c035d0350b06e767d064f73457b0db056f51647\build\Debug
ERROR: libpng/1.6.38: Error in build() method, line 166
        self._patch_source()
while calling '_patch_source', line 108
        replace_in_file(self, os.path.join(self.source_folder, "CMakeLists.txt"),
        ConanException: replace_in_file didn't find pattern 'COMMAND "${CMAKE_COMMAND}" -E copy_if_different $<TARGET_LINKER_FILE_NAME:${S_TARGET}> $<TARGET_LINKER_FILE_DIR:${S_TARGET}>/${DEST_FILE}' in 'C:\Users\adn\.conan\data\libpng\1.6.38\_\_\build\1c035d0350b06e767d064f73457b0db056f51647\src\CMakeLists.txt' file.

[ericLemanissier]

Ok, I pushed another fix (hopefully the last one). Can you please retry ?

[Adnn]

Great: it now works in my environment!

Thank you @ericLemanissier.