[package] sqlite3/all: Discussion of default options

Having a look at the options of the sqlite3 recipe you see most of them defaulted to false. However, there are some recipes like qt from bincrafters that already require this package with specific option enabled:

https://github.com/bincrafters/conan-qt/blob/594e40f036adcbf22d23dc2da228f389d45a76dc/conanfile.py#L256

Moreover, the sqlite3 is provided with a custom CMakeLists.txt with the CMake options, so we could say there are no defaults for these options recommended by the library authors/maintainers.

Additionally, these options are enabled by default in vcpkg repo:

-DSQLITE_ENABLE_RTREE
-DSQLITE_ENABLE_UNLOCK_NOTIFY
-DSQLITE_ENABLE_COLUMN_METADATA

This issue is open for discussion regarding the options of this package and its default values.

cc/ @ericLemanissier @SSE4 @uilianries

[SSE4]

my 2 cents, looking at sqlite3 options:

• column_metadata - enables additional APIs, making library more feature complete. almost harmless (the only side-effect is a bit larger library, but cost is very low IMO)
• threadsafe - very contradictory. enabling it makes library more safe and stable, but has a significant performance penalty. this is something that depends on consumer’s usage (does he call sqlite3 APIs from different threads?). so it appears option should be enabled only if it’s really needed (default = false)
• rtree - another API extension, should be safe to enable by default
• unlock_notify - one more API extension therefore, we may safely enable all API extensions by default (column metadata, rtree, unlock notify). for threadsafe - I vote for false by default. if possible, build both threadsafe=false and threadsafe=true.

[danimtb]

So let’s add the same api extensions options as in vcpkg and keep the threadsafe one as is