Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

[question] sqlite3 default options

See original GitHub issue

Just tried to take a sqlite3 as my dependency and I see that conan-center-index default options does not match the one in the SQLite documentation:

This option controls whether or not code is included in SQLite to enable it to operate safely in a multithreaded environment. The default is SQLITE_THREADSAFE=1

Whereas in conan-center-index it is: https://github.com/conan-io/conan-center-index/blob/master/recipes/sqlite3/all/conanfile.py#L32

What is the aproach here - shouldnt packages try to match default behavior? If thats the case I can review the flags and make a pr possibly.

Issue Analytics

State:
Created 3 years ago
Reactions:3
Comments:7 (7 by maintainers)

Top GitHub Comments

2reactions

ericLemanissiercommented, Apr 20, 2020

The fact that sqlitepp requires a specific value does not imply that it has to be the default. It means that it should be built by CCI too. Keeping defaults consistent with the packaged library should be the rule. And as @fulara said, vcpkg seems to actually use the actual default value.

EDIT: also, it seems that sqlitecpp supports threadsafe=1 : https://github.com/SRombauts/SQLiteCpp/issues/195#issuecomment-488113454

0reactions

madebrcommented, May 6, 2020

I’ve been bitten by this as well in #1570 The poco recipe requires thread safety to be nonzero.