Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

specify patches in conandata.yaml

See original GitHub issue

it’s often needed to specify patches to apply, and list of patches may vary from version to version. we may use something like:

patches:
    1.70.0:
        - "001-xxx"
        - "002-xxxx"

it also would be nice to ensure every recipe uses the same format. consider use some sort of schema to validate conandata.yml has only allowed fields.

Issue Analytics

State:
Created 4 years ago
Reactions:2
Comments:13 (13 by maintainers)

Top GitHub Comments

4reactions

lasotecommented, Sep 25, 2019

@conan-io/barbarians Let’s decide something here about this. Any objection about specifying patches in the conandata.yml? Agreed with the format?

patches:
    1.70.0:
        - "001-xxx"
        - "002-xxxx"

@memsharded about our conversation about “peeling” the conandata being exported to avoid creating new recipe revisions when only new version keys are added we would be ok, but only if we agree on the “standard” key and introduce checks of known keys in the CI.

3reactions

Croydoncommented, Oct 3, 2019

Maybe we should keep it uniform no matter if it is a single patch or several.

By that way we would always get a list back or could maybe improve tools.patch() to support this as well. This would allow to manage patches truly in conandata.yml without code changes (adding or removing a loop like for patch in patches:)