question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Incorrectly interpreting `skip: True # [not py35]` line

See original GitHub issue

When using conda smithy rerender on a recipe that contains this line (skip: True # [not py35]), it is removing appveyor.yml and .travis.yml, as if it had to skip all platforms.

Issue Analytics

  • State:closed
  • Created 7 years ago
  • Comments:11 (11 by maintainers)

github_iconTop GitHub Comments

1reaction
tadeucommented, Jan 11, 2017

In your case, @tadeu, I think conda-smithy, conda-build-all maybe even conda-build should complain that a py selector is being used when python is not a requirement. It results in a strange skip platform case that is not obvious initially. I don’t know if that is enough of a hint, but it would at least get one to poke around in the right places. Not sure if this warning should come out of the linter or conda-smithy directly. Would be happy to discuss all of this with you and others in a new issue.

@jakirkham I agree, thanks for looking into this. The not py35 is there just for ensuring it will not build more than one package with the same name, but I agree it seems weird if there’d no requirement for python.

0reactions
tadeucommented, Jan 11, 2017

Interesting. Also what happened to the build/features in that commit @tadeu ?

@jakirkham I’ve removed it, since doxygen doesn’t seem to need a runtime (it is copied from the binary distribution, which doesn’t include any runtime. I’ve confirmed it with dependency walker).

Read more comments on GitHub >

github_iconTop Results From Across the Web

conda-forge/conda-forge.github.io - Gitter
The feedstock creation may have a bug interpreting that pre-processor. ... I re-rendered it with skip: True # [not win or py2k] and...
Read more >
Defining metadata (meta.yaml) - Conda
py files that should not be compiled yet, because the Python interpreter that will be used is not known at build time. In...
Read more >
Changelog - isort
Fixed #1667: extra newline added with float-to-top, after skip, in some cases. Fixed #1594: incorrect placement of noqa comments with multiple from imports....
Read more >
tox Documentation - Read the Docs
Setting this to True is equivalent of passing the --skip-missing-interpreters command line option, and will force tox to return success even ...
Read more >
tox 3.1.3 - PyPI
tox is a generic virtualenv management and test command line tool you can use ... with incorrectly defactorized dependencies (deps passed to pip...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found