Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.
And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.
[BUG] Also add NOTICE if it is present in package
See original GitHub issueDescribe the bug A clear and concise description of what the bug is.
Some licenses ship with a separate NOTICE file. This file is currently not included, only the license is. As some licenses say that the notice should be included as well, it would be great if Grayskull could add it automatically, like it does with the license itself.
To Reproduce Steps to reproduce the behavior:
- Add a package
Expected behavior A clear and concise description of what you expected to happen.
LICENSE and NOTICE are added
Outputs If applicable, add the output to help explain your problem.
Something like this:
license_file:
- LICENSE
- NOTICE
Environment: Everywhere
Additional context Add any other context about the problem here.
Issue Analytics
- State:
- Created a year ago
- Reactions:1
- Comments:8 (8 by maintainers)
Top Results From Across the Web
Top Related Medium Post
Top Related StackOverflow Question
Troubleshoot Live Code
Top Related Reddit Thread
Top Related Hackernoon Post
Top Related Tweet
Top Related Dev.to Post
Top Related Hashnode Post
yeah, I just merged a PR that is doing exactly what you mentioned. I also added a message when it finds multiple licences, so the user needs to review it
Generally from what I saw it’s that only one is the license and the other one is a copyright disclaimer.
Otherwise they could be joined by AND?