question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

[BUG] Also add NOTICE if it is present in package

See original GitHub issue

Describe the bug A clear and concise description of what the bug is.

Some licenses ship with a separate NOTICE file. This file is currently not included, only the license is. As some licenses say that the notice should be included as well, it would be great if Grayskull could add it automatically, like it does with the license itself.

To Reproduce Steps to reproduce the behavior:

  1. Add a package

Expected behavior A clear and concise description of what you expected to happen.

LICENSE and NOTICE are added

Outputs If applicable, add the output to help explain your problem.

Something like this:

license_file:
  - LICENSE
  - NOTICE

Environment: Everywhere

Additional context Add any other context about the problem here.

Issue Analytics

  • State:closed
  • Created a year ago
  • Reactions:1
  • Comments:8 (8 by maintainers)

github_iconTop GitHub Comments

2reactions
marcelotrevisanicommented, Jul 20, 2022

yeah, I just merged a PR that is doing exactly what you mentioned. I also added a message when it finds multiple licences, so the user needs to review it

1reaction
BastianZimcommented, Jul 20, 2022

Generally from what I saw it’s that only one is the license and the other one is a copyright disclaimer.

Otherwise they could be joined by AND?

Read more comments on GitHub >

github_iconTop Results From Across the Web

[BUG] npm ci can't resolve dependencies without --force, or ...
Now I have to put legacy-peer-deps=true in .npmrc and I won't get an error when I try to install something with outdated peer...
Read more >
HowtoUseBTS - Debian Wiki
To do this, you can go to http://bugs.debian.org/packagename to get a list of all the bug reports for a given package. Note that...
Read more >
What should be done after a bug is found (Bug Defect ...
While testing if you observed any bug, add this bug to the bug defect tracking tool immediately, don't wait to write bug in...
Read more >
Status report should warn about OPcache bug in PHP 8.1.0 to ...
This is an intermittent bug that seems to appear at a frequency of every few days. So far it has only been reported...
Read more >
Bug descriptions — spotbugs 4.7.3 documentation
This method can be invoked as though it returned a value of type boolean, and the compiler will insert automatic unboxing of the...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found