question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

[contracts] Interface changes

See original GitHub issue

Need to finalize interface changes that we have gotten suggestions on from users.

Things that could be important:

  • adding in a receivingAsset that can be the local or adopted asset for that chain
  • adding in a way to specify slippage boundaries
  • adding in xcallExactOut path -> can do this in an upgrade since only additive if needed
  • specifying if you want to use slow or fast liquidity
  • add getExecutor() to IConnextHandler.sol to expose the executor via interface. similar to how we have getConnext() in IExecutor.sol

cc @just-a-node – if there’s any other feedback you’ve been getting now is the time to surface it!

Issue Analytics

  • State:closed
  • Created a year ago
  • Comments:18 (18 by maintainers)

github_iconTop GitHub Comments

2reactions
rhlsthrmcommented, May 12, 2022

Instead of sending it back through the bridge, they should just be able to retrieve their funds in madAssets and they can send back manually later right? We can wrap this up in a UI but I don’t think this needs to explicitly be part of the protocol.

1reaction
just-a-nodecommented, May 10, 2022

Another request:

  • add getExecutor() to IConnextHandler.sol to expose the executor via interface. similar to how we have getConnext() in IExecutor.sol
Read more comments on GitHub >

github_iconTop Results From Across the Web

ParallelChange - Martin Fowler
Parallel change, also known as expand and contract, is a pattern to implement backward-incompatible changes to an interface in a safe manner, by ......
Read more >
Solidity Tutorial: all about interfaces | by Jean Cvllr - Medium
The contracts inheriting from the interface will have to implement all the functions defined in the interface.
Read more >
Contracts — Solidity 0.8.17 documentation
External functions are part of the contract interface, which means they ... Modifiers can be used to change the behaviour of functions in...
Read more >
These Small Changes in Interface Design Could Save You ...
These Small Changes in Interface Design Could Save You From Big Legal Headaches. Users must be notified of terms in a conspicuous manner...
Read more >
Explaining how an Interface is a contract
Most students in that age-range have no personal experience with contracts, so the term is too abstract or remote. Secondly, using contract to...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found