Block replace - invalid flow

Hi

I work on my own naive implementation and I study yours. I think I have found some invalid flow. In chain implementation you do following:

1. replaceChain(newChain) you call checkChain
2. it calls checkBlock
3. it calls checkTransaction
4. this check if transaction isn’t already in your chain here

Problem with it is that you check this way whole new chain, not only new blocks as you do slice after the check here

This way any try to check chain that contains shared transaction history with your chain will be invalid. Or I don’t understand something.

[conradoqg]

Hey

I think it was easy to do that way, indeed, only checking from the shared parent forward is valid and has more performance.

In some extreme cases, it’s possible that a new blockchain totally replaces the current one, but even in that case, the only change is that we check the genesis and forward. (and the genesis becomes the shared parent).

Best

[conradoqg]

Agree. Thanks for your help. I’ll keep this improvement in mind and I’ll add it to a list of desired improvements.