Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Block replace - invalid flow

See original GitHub issue

Issue Description

I work on my own naive implementation and I study yours. I think I have found some invalid flow. In chain implementation you do following:

replaceChain(newChain) you call checkChain
it calls checkBlock
it calls checkTransaction
this check if transaction isn’t already in your chain here

Problem with it is that you check this way whole new chain, not only new blocks as you do slice after the check here

This way any try to check chain that contains shared transaction history with your chain will be invalid. Or I don’t understand something.

Issue Analytics

State:
Created 5 years ago
Comments:7 (4 by maintainers)

Top GitHub Comments

1reaction

conradoqgcommented, Jan 9, 2018

Hey

I think it was easy to do that way, indeed, only checking from the shared parent forward is valid and has more performance.

In some extreme cases, it’s possible that a new blockchain totally replaces the current one, but even in that case, the only change is that we check the genesis and forward. (and the genesis becomes the shared parent).

Best

0reactions

conradoqgcommented, Jan 24, 2018

Agree. Thanks for your help. I’ll keep this improvement in mind and I’ll add it to a list of desired improvements.