Inconsistencies in Database Importer

Prerequisites

• Put an X between the brackets on this line if you have done all of the following:

  • Running the latest version of Constellation

  • Attached the Support Package via Help > Support Package

  • Checked the FAQs: https://github.com/constellation-app/constellation/wiki/FAQ

  • Checked that your issue isn’t already filed: https://github.com/constellation-app/constellation/issues

  • Checked that there is not already a module that provides the described functionality: https://github.com/constellation-app/constellation/wiki/Catalogue-of-Repositories

Description

1. The same error message added in #1359 when there are empty mandatory fields in the Add Connections window, can be added in the Add Drivers window for consistency, although there’s only one field which is of course mandatory.

2. Some brief description in PromptText similar to Add Connections window would be nice, again for consistency:

1. Noticed an issue with the import status message when there is a filter applied. I guess it should only display the number of rows that are actually drawn on the graph. This looks more like a bug if the filter doesn’t select any rows, as it doesn’t draw anything on the graph but the message says it has imported some rows.

Steps to Reproduce

1. Open constellation and open Import From Database window and try above

Expected behaviour: Be consistent

Actual behaviour: Not consistent

Reproduces how often: 100%

Additional Information

[GammaVel]

Thanks @Auriga2 for fixing all these issues, you sure have improved the overall functionality here. They are looking great and I have been enjoying the improvements with importing data from my sqlite DB. I did notice a few minor issues in general relating to importing from a DB which I have just created new tickets for. I think this is because I haven’t been using this functionality very much lately so a few things stood out to me that we could do to make it even better!

[Auriga2]

Yes it should handle this issue. Thanks Antares, I was about to create a new ticket for this. Arcturus has suggested the 1st solution there, which makes sense and less confusing to users.