JDBC Importer Fixes

Prerequisites

• Put an X between the brackets on this line if you have done all of the following:
  • Running the latest version of Constellation
  • Attached the Support Package via Help > Support Package
  • Checked the FAQs: https://github.com/constellation-app/constellation/wiki/FAQ
  • Checked that your issue isn’t already filed: https://github.com/constellation-app/constellation/issues
  • Checked that there is not already a module that provides the described functionality: https://github.com/constellation-app/constellation/wiki/Catalogue-of-Repositories

Description

The following issues we’re identified by @cygnus-x-1 when testing the JDBC importer:

• You currently cannot add a connection without entering a username / password, even if it is not required.
• I’m unclear why there is an option for a username and password as that information was requested as part of the connection setup. Perhaps it was only needed for testing the connection there? If that’s the case, then the UI should indicate that.
• The instructions in the ‘Configuration’ pane don’t actually mention that you need to perform an SQL query to retrieve sample data before dragging and dropping attributes.
• I am unable to perform metadata queries of a database (.table, .schema , etc) as they fail validation.

Steps to Reproduce

1. [First Step]
2. [Second Step]
3. [and so on…]

Expected behaviour: [What you expect to happen]

Actual behaviour: [What actually happens]

Reproduces how often: [What percentage of the time does it reproduce?]

Additional Information

Any additional information, configuration or data that might be necessary to reproduce the issue.

[Auriga2]

The issue with the SQLite DB mentioned in https://github.com/constellation-app/constellation/issues/141 could be reproduced and it was thrown when the ResultSetMetaData (PreparedStatement.getMetaData()) was called after all of the rows of the ResultSet have been consumed, i.e., rs.next() has been called until it returns false.

Easily fixed by moving that part of the code down, which wouldn’t make any difference on other databases.

When the username and password are not required, I can just leave those fields blank.

[Auriga2]

With all the error pop ups, the exception was also thrown by the LOGGER.log(). Fixed that also. The Add Drive window now lists the Name under the Driver and Name auto populates the first item when the Driver is selected. I left the drop down, in case there could be multiple items for certain drivers perhaps.