question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Many instances of "DAV Pane Creator" running.

See original GitHub issue

Prerequisites

Description

This may be effecting performance, but either way it seems bad to just have the threads waiting endlessly. Even after exiting the view, all creator threads remain. Launching the DAV again, does not yield more threads.

Steps to Reproduce

  1. Open new graph
  2. Open Data Access View

Expected behaviour: less threads

Actual behaviour: many threads image

Reproduces how often: 100%

Additional Information

N/A

Issue Analytics

  • State:closed
  • Created 3 years ago
  • Reactions:1
  • Comments:5 (2 by maintainers)

github_iconTop GitHub Comments

2reactions
aldebaran30701commented, Jan 21, 2022

After some investigation, the threads of the thread pool executor stick around because they might be used later on to create new DAV tabs (runs). If the executor was shut down after the initial loading of tab 1 parameters, there was no noticable saving in memory or gain in performance. When a new tab (run) needed to be added, the executor would then need to initialise a new thread pool as the previous one was closed. This may introduce more performance degradation than leaving the threads running.

From the below photos, you can see that there is negligible difference in either keeping them around or getting rid of them. I think from this investigation, it is obvious that the best course of action to leave the current implementation alone.

With threads running: image

Without threads running: image

I vote to close this ticket with no further action.

0reactions
antares1470commented, Jun 29, 2021

To quote the javadoc for Executors.newFixedThreadPool: “The threads in the pool will exist until it is explicitly shutdown”.

Having had a quick look in the code, it doesn’t appear shutdown() is called so this is probably why the threads are lingering

Read more comments on GitHub >

github_iconTop Results From Across the Web

Untitled
Registration of a new ODS account or login as DBA or DAV account. ... As result will be shown the Community instances with...
Read more >
How to Play DAV Files in VLC - Wondershare UniConverter
Learn more about how to play DAV file in VLC in the following parts. ... and from the left-side panel, select Demuxers under...
Read more >
Working with Normalization Rules - Ex Libris Knowledge Center
To apply normalization rules to such records, run the normalization rules and ... The rule is displayed in the right pane of the...
Read more >
How To Configure WebDAV Access with Apache on Ubuntu ...
You enable the WebDAV module for Apache using the a2enmod utility. The following two commands will enable the WebDAV modules: sudo a2enmod dav. ......
Read more >
[SOLVED] Windows 10 100% disk usage in Task Manager
Fix 1: Disable SuperFetch · 1) On your keyboard, press Windows logo key, type command prompt, then select Run as administrator. · 2)...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found