Split Nodes Plugin always adding Correlation between the split nodes

Prerequisites

• Put an X between the brackets on this line if you have done all of the following:
  • Running the latest version of Constellation
  • Attached the Support Package via Help > Support Package
  • Checked the FAQs: https://github.com/constellation-app/constellation/wiki/FAQ
  • Checked that your issue isn’t already filed: https://github.com/constellation-app/constellation/issues
  • Checked that there is not already a module that provides the described functionality: https://github.com/constellation-app/constellation/wiki/Catalogue-of-Repositories

Description

When running the Split Nodes plugin, the transaction type created between the nodes is always a Correlation regardless of what is actually selected

Steps to Reproduce

1. Draw 2 nodes and draw a transaction between them
2. Rename one of the nodes to ‘abc;def;ghi’
3. Open up Data Access View and go to Split Nodes plugin
4. Set the split character as ‘;’ and the transaction type to any type other than a Correlation
5. Ensure the renamed node is selected and run the plugin

Expected behaviour: The transaction(s) formed from the plugin are of the type selected for the Transaction Type parameter

Actual behaviour: The transaction(s) formed from the plugin are of the type Correlation

Reproduces how often: 100%

Additional Information

[Auriga2]

It has a similar code, so if the “Content” is there in the drop down, it’ll use “Content” instead of the user selected value. I’ll add a check there as well.

[Auriga2]

@arcturus2 : This is due to the below code from SplitNodesPlugin.java Therefor if “Correlation” exists in the list, it’ll overwrite the selection.

        if (types.contains(AnalyticConcept.TransactionType.CORRELATION.getName())) {
            SingleChoiceParameterType.setChoice(transactionType, AnalyticConcept.TransactionType.CORRELATION.getName());
        }

What is the exact behaviour required here? May be default it only if no value is selected?