question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Standardize UPPER vs Camel case OK/Ok buttons

See original GitHub issue

Mix of UPPER and Camel case OK/Ok buttons

UPPER case OKs:

" constellation/CoreFindView/src/au/gov/asd/tac/constellation/views/find/gui/ColorCriteriaPanel.java"
        if ("OK".equals(e.getActionCommand())) {
" constellation/CoreFindView/src/au/gov/asd/tac/constellation/views/find/gui/ColorPropertyEditor.java"
        if ("OK".equals(e.getActionCommand())) {
" constellation/CoreFindView/src/au/gov/asd/tac/constellation/views/find/gui/IconCriteriaPanel.java"
        if ("OK".equals(e.getActionCommand())) {
" constellation/CoreFindView/src/au/gov/asd/tac/constellation/views/find/gui/IconPropertyEditor.java"
        if ("OK".equals(e.getActionCommand())) {
" constellation/CoreFindView/src/au/gov/asd/tac/constellation/views/find/gui/StringCriteriaPanel.java"
        if (e.getActionCommand().equals("OK")) {
" constellation/CoreFunctionality/src/au/gov/asd/tac/constellation/functionality/dialog/ItemsDialog.java"
 * The dialog will have the following buttons of which the "OK" button can be
" constellation/CoreGraphUtilities/src/au/gov/asd/tac/constellation/graph/utilities/hashmod/HashmodAction.java"
            if (e.getActionCommand().equals("OK")) {
" constellation/CoreOpenGLDisplay/src/au/gov/asd/tac/constellation/visual/opengl/utilities/LabelFontsOptionsPanel.java"
            validateLabel.setText("OK");
" constellation/CorePluginFramework/src/au/gov/asd/tac/constellation/plugins/gui/PluginParametersDialog.java"
    public static final String OK = "OK";
     * "OK" and "Cancel" buttons are displayed.
" constellation/CorePluginFramework/src/au/gov/asd/tac/constellation/plugins/gui/PluginParametersSwingDialog.java"
    public static final String OK = "OK";
     * "OK" and "Cancel" buttons are displayed.
     * "OK" and "Cancel" buttons are displayed.
     * "OK" and "Cancel" buttons are displayed.
     * "OK" and "Cancel" (and "Help" if helpID is non-null) buttons are
" constellation/CoreQualityControlView/test/unit/src/au/gov/asd/tac/constellation/views/qualitycontrol/event/QualityControlEventNGTest.java"
        categoryString = "OK";
" constellation/CoreTableView/src/au/gov/asd/tac/constellation/views/tableview/TableViewTopComponent.java"
        final JButton okButton = new JButton("OK");
        }, "OK", DialogDescriptor.DEFAULT_ALIGN, null, (final ActionEvent e) -> {
            if (e.getActionCommand().equals("OK")) {

Lower case Oks:

" constellation/CoreImportExportPlugins/src/au/gov/asd/tac/constellation/plugins/importexport/AttributeNode.java"
                    parameters, "Ok", "Cancel"); <<< LOWER CASE
" constellation/CorePluginFramework/src/au/gov/asd/tac/constellation/plugins/PluginInteraction.java"
     * @return true if the user selected "Ok" or false if the user selected  << LOWER CASE
" constellation/CoreAttributeEditorView/src/au/gov/asd/tac/constellation/views/attributeeditor/AttributeEditorDialog.java"
        okButton = new Button("Ok"); << LOWER CASE
" constellation/CoreImportExportPlugins/src/au/gov/asd/tac/constellation/plugins/importexport/DefaultAttributeValueDialog.java"
        final Button okButton = new Button("Ok");  << LOWER CASE
" constellation/CoreImportExportPlugins/src/au/gov/asd/tac/constellation/plugins/importexport/NewAttributeDialog.java"
        final Button okButton = new Button("Ok");  << LOWER CASE
" constellation/CoreNamedSelectionView/src/au/gov/asd/tac/constellation/views/namedselection/NamedSelectionManager.java"
        dd.setOptions(new Object[]{"Ok"});  << LOWER CASE
        dd.setOptions(new Object[]{"Ok"});  << LOWER CASE
" constellation/CoreNamedSelectionView/src/au/gov/asd/tac/constellation/views/namedselection/NamedSelectionTopComponent.java"
        dd.setOptions(new Object[]{"Ok"});  << LOWER CASE

Issue Analytics

  • State:closed
  • Created 2 years ago
  • Reactions:1
  • Comments:9

github_iconTop GitHub Comments

1reaction
CrucisGammacommented, Sep 15, 2021

Hey all - I’d argue for the ‘OK’ over ‘Ok’, just based on linux/windows all do Upper OK

image

Also macos seems to do ‘OK’ image

1reaction
antares1470commented, Sep 13, 2021

I personally think moving all to Camel case ‘Ok’ is the way to go

Read more comments on GitHub >

github_iconTop Results From Across the Web

Pascal case vs. camel case: What's the difference? | TechTarget
The difference is that Pascal case requires the first letter to be uppercase as well, while camel case does not.
Read more >
What is the CamelCase naming convention? - TechTarget
CamelCase is a way to separate the words in a phrase by making the first letter of each word capitalized and not using...
Read more >
Camel Case vs. Snake Case vs. Pascal Case - Khalil Stemmler
Camel case, pascal case, and snake case are the three most common naming conventions in modern programming languages.
Read more >
Snake Case VS Camel Case VS Pascal Case VS Kebab Case
The only difference between the two is that pascal case requires the first letter of the first word to also be capitalized. So,...
Read more >
CamelCase vs underscores: Scientific showdown - whatheco.de
Results indicate that camel casing leads to higher accuracy among all subjects regardless of training, and those trained in camel casing are ...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found