Too many levels of error messages

Prerequisites

• Put an X between the brackets on this line if you have done all of the following:
  • Running the latest version of Constellation
  • Attached the Support Package via Help > Support Package
  • Checked the FAQs: https://github.com/constellation-app/constellation/wiki/FAQ
  • Checked that your issue isn’t already filed: https://github.com/constellation-app/constellation/issues
  • Checked that there is not already a module that provides the described functionality: https://github.com/constellation-app/constellation/wiki/Catalogue-of-Repositories

Description

When running either the Merge Nodes, Merge Transactions, or Select Top N plugins when not all the information required for the plugin has been entered, you will receive error messages and a plugin exception. Perhaps only the 3rd error window should appear or maybe a more meaningful window so that the user can understand what information they didn’t enter properly.

Steps to Reproduce

1. Select one of the listed plugins
2. Click the “Go” button

Expected behaviour: A window should appear explaining what information the user didn’t enter

Actual behaviour: 2 error windows and an exception appear

Reproduces how often: 100%

Additional Information

[serpens24]

I have reproduced this problem in the debugger to identify where/when these dialogs and exceptions are being thrown. They are:

1. Within the exception handler of SimpleQueryPlugin.run() with a call to interaction.notify, this displays the longer of the two ‘Select Top N’ error dialog. (lines 173-179):

                    } catch (Exception e) {
                        final String msg = Bundle.MSG_Query_Failed(graph, getName());
                        interaction.notify(PluginNotificationLevel.ERROR, msg + "\n" + e.getMessage());
                        cancelled = true;
                        LOGGER.log(Level.WARNING, msg, e);
                        throw e;
                    }

1. Within the exception handler of DefaultPluginEnvironment.executePluginLater(), this is actually a result of the ‘throw e’ propagating the exception up from SimpleQueryPlugin.run(), above. This results in the shorter of the two ‘Select Top N’ error dialogs.

            } catch (PluginException ex) {
                auditPluginError(plugin, ex);
                interaction.notify(ex.getNotificationLevel(), ex.getMessage());
                ex.printStackTrace();
                if (currentReport != null) {
                    currentReport.setError(ex);
                }
            }

1. The bottom exception showing a stack trace is actually throwing inadvertantly as a result of the LOGGER.log(Level.WARNING, msg, e); call within the first code example above. Clearly this isn’t the desired outcome. I found that by removing the exception (e) as a final parameter still results in the LOGGER correctly logging the error to the error log, but without the exception being thrown. As the code currently exists, the following log extract is what is produced by the LOGGER call:

FINE [au.gov.asd.tac.constellation.plugins.PluginExecution]: Select Top N
INFO [au.gov.asd.tac.constellation.views.dataaccess.panes.DataAccessPane]: Plugins run.
Select Top N: Action failed: au.gov.asd.tac.constellation.graph.locking.DualGraph@757edcf4; Select Top N
Select a type category
WARNING [au.gov.asd.tac.constellation.plugins.templates.SimpleQueryPlugin]: Action failed: au.gov.asd.tac.constellation.graph.locking.DualGraph@757edcf4; Select Top N
au.gov.asd.tac.constellation.plugins.PluginException: Select a type category
	at au.gov.asd.tac.constellation.views.dataaccess.plugins.utility.SelectTopNPlugin.edit(SelectTopNPlugin.java:206)
	at au.gov.asd.tac.constellation.plugins.templates.SimpleQueryPlugin.describedEdit(SimpleQueryPlugin.java:265)
[catch] at au.gov.asd.tac.constellation.plugins.templates.SimpleQueryPlugin.run(SimpleQueryPlugin.java:165)
	at au.gov.asd.tac.constellation.graph.node.plugins.DefaultPluginEnvironment.lambda$executePluginLater$0(DefaultPluginEnvironment.java:123)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
	at java.base/java.lang.Thread.run(Thread.java:834)
SEVERE [au.gov.asd.tac.constellation.graph.node.plugins.DefaultPluginInteraction]: Select Top N: Select a type category
au.gov.asd.tac.constellation.plugins.PluginException: Select a type category
	at au.gov.asd.tac.constellation.views.dataaccess.plugins.utility.SelectTopNPlugin.edit(SelectTopNPlugin.java:206)
	at au.gov.asd.tac.constellation.plugins.templates.SimpleQueryPlugin.describedEdit(SimpleQueryPlugin.java:265)
	at au.gov.asd.tac.constellation.plugins.templates.SimpleQueryPlugin.run(SimpleQueryPlugin.java:165)
	at au.gov.asd.tac.constellation.graph.node.plugins.DefaultPluginEnvironment.lambda$executePluginLater$0(DefaultPluginEnvironment.java:123)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
	at java.base/java.lang.Thread.run(Thread.java:834)

By removing the ‘e’ from the call the following is what is produced by the LOGGER call:

INFO [au.gov.asd.tac.constellation.views.dataaccess.panes.DataAccessPane]: Plugins run.
Select Top N: Action failed: au.gov.asd.tac.constellation.graph.locking.DualGraph@d837407; Select Top N
Select a type category
WARNING [au.gov.asd.tac.constellation.plugins.templates.SimpleQueryPlugin]: Action failed: au.gov.asd.tac.constellation.graph.locking.DualGraph@d837407; Select Top N
SEVERE [au.gov.asd.tac.constellation.graph.node.plugins.DefaultPluginInteraction]: Select Top N: Select a type category
au.gov.asd.tac.constellation.plugins.PluginException: Select a type category
	at au.gov.asd.tac.constellation.views.dataaccess.plugins.utility.SelectTopNPlugin.edit(SelectTopNPlugin.java:206)
	at au.gov.asd.tac.constellation.plugins.templates.SimpleQueryPlugin.describedEdit(SimpleQueryPlugin.java:265)
	at au.gov.asd.tac.constellation.plugins.templates.SimpleQueryPlugin.run(SimpleQueryPlugin.java:165)
	at au.gov.asd.tac.constellation.graph.node.plugins.DefaultPluginEnvironment.lambda$executePluginLater$0(DefaultPluginEnvironment.java:123)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
	at java.base/java.lang.Thread.run(Thread.java:834)

[arcturus2]

@formalhaut69 so I had this issue tracked in my internal issues list so I’ve just added to yours and updated the title…hope your ok with that 😄.