Proposal: forma-36-react-date-components
See original GitHub issueHey lovely people 👋
I’m here with another proposal about date components.
One artifact of the brand new scheduled publishing feature is 3 UI components to enter and select dates, time and timezones. I want to move these components to Forma 36 for you to reuse so I’m proposing a new package called forma-36-react-date-components
.
This package will include the following components:
DatePicker
TimePicker
TimezonePicker
FormattedDate -> Utility component the formats date in Forma-36 compliant formats
Why is this a new package?
These components will have a peer dependency on moment.js (or date-fns up for discussion…) which I don’t want to force the consumer of our forma-36-react-components
package to install.
Ideas & comments are as always much appreciated ❤️
Thanks!
Issue Analytics
- State:
- Created 4 years ago
- Comments:8 (7 by maintainers)
Top GitHub Comments
Nice, components sound great! My only concern is grouping all of these things in one package. We’ve discussed the possibility of going for a one-component-per-package and I feel like this single
forma-36-react-date-components
package could be a little short-sighted. So instead I’d recommend building out each component as a separate package like so:forma-36-react-components/date-picker
forma-36-react-components/time-picker
forma-36-react-components/time-zone-picker
forma-36-react-components/formatted-date
Thanks all for the feedback the first Datepicker component was released, more component to follow 🎉 : https://www.npmjs.com/package/@contentful/forma-36-react-datepicker