Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Add `className` prop to all components

See original GitHub issue

Relying on class names is brittle, risking typos (or making string constants necessary) and opening up an escape hatch to meddle with the insides of components. It is better to remove className props entirely and rely on emotion component-based styling instead.

After running into some tricky-to-debug styling errors using the components, the scope of this PR has changed. Read along 😃

Issue Analytics

State:
Created 5 years ago
Reactions:1
Comments:7 (7 by maintainers)

Top GitHub Comments

1reaction

fabien0102commented, Jul 9, 2018

I think that we can try this pattern for our module -> https://github.com/pedronauck/docz/blob/master/examples/typescript/src/components/Alert.tsx

So we retrieve all native react props (including classname), and it’s pretty 😎

1reaction

TejasQcommented, Jul 6, 2018

I’m totally in favor of allowing a className prop everywhere. I think it makes sense for components to receive classNames all the time, but not ad-hoc css styles.

Good catch, Peter!