Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

FIX THE SPINNER COLOR ON BUTTONS

See original GitHub issue

The Problem

Currently, we have an issue with buttons that contain spinners that have non-white backgrounds. Play here.

You’ll want to change the background color of a spinning button in the playground to be something non-white to see the issue.

The Fix

./src/Button/Button.tsx should style the <Spinner /> in it to be <Spinner color={readableTextColor(buttonColor)} />.

-<Spinner />
+<Spinner color={readableTextColor(buttonColor)} />

Issue Analytics

State:
Created 5 years ago
Comments:5 (5 by maintainers)

Top GitHub Comments

1reaction

TejasQcommented, Aug 6, 2018

I think using currentColor:

a) is unpredictable and breaks opinionation of Operational UI, rendering spinners that magically take the text color of their containers,

b) does not clearly describe intent to color the spinner at the codebase level.

For these reasons, I do not think using currentColor makes sense and recommend explicity setting values in order to avoid surprises going forward, while maintaining the opinionated-nature of Operational.

0reactions

TejasQcommented, Aug 6, 2018

I see your point. I agree. Let’s use currentColor.