Lightrun
question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Icon instance vs class in Input component.

See original GitHub issue

At the moment, there are 2 Input props concerning icons: statusIcon and placeholderIcon.

statusIcon is passed in as an icon instance, so that the user has more control over styling. placeholderIcon is currently the same, for consistency within the component, but it would make more sense for its size, colour etc. to be fixed.

The proposal is to remove statusIcon entirely from Input (Input already has too many options, and the user could just position an icon next to the input) and change placeholderIcon to a React component (type: IconComponentType).

Issue Analytics

  • State:open
  • Created 4 years ago
  • Reactions:1
  • Comments:5 (5 by maintainers)

github_iconTop GitHub Comments

1reaction
ImogenFcommented, Jun 21, 2019

In that case maybe we could have ID fields as a separate component that extends Input, rather than having an isUniqueId prop on the Input component.

0reactions
stereoboostercommented, Jun 21, 2019

image

I mean those

Read more comments on GitHub >

github_iconTop Results From Across the Web

React Components, Elements, and Instances – React Blog
Class components have instances, but you never need to create a component instance directly—React takes care of this.
Read more >
Construct component selector via an @Input - angular
How does one construct a selector programmatically in Angular? Let's say I have a parent component called header.component which looks like this ...
Read more >
Input | Element Plus
Input is a controlled component, it always shows Vue binding value. ... Its handler should update component's binding value (or use v-model )....
Read more >
Display a lightning:icon inside lightning:input
The Lightning Design System docs have a lot of good information regarding your different options for displaying icons within HTML inputs.
Read more >
<input>: The Input (Form Input) element - HTML
Opens a date picker or numeric wheels for date- and time-components when active in supporting browsers. ... A field for editing an email...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found
Previous page

AvatarGroup negative margin breaks design

Next page

[Umbrella] Migrate to Hooks