question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

  • All grey stripes between cards (or card and sidebar) should be 16px wide / high
  • Padding right/left of sidebar content should be 12px
  • The caret symbol when pointing downwards needs to be offset 2px from the top when compared to pointing right (in the sidebar)
  • Add border: 3px solid #dadada; around boxes that have non-white backgrounds (e.g. color palette, images on card page, code playgrounds)
  • Default text color: #555f61
  • Headers / emphasis: #373d3f
  • Box shadow for cards should be 0px 1px 2px #d3d1d1
  • Card header bottom border should be #f2f2f2
  • Use font-family: Menlo, Consolas, 'DejaVu Sans Mono', monospace for code playground
  • Use 12px 12px 10px 12px as padding for card header
  • Set code playground background to #282c35
  • Use letter-spacing: normal
  • Default “white” buttons: –> border-color: #e2e2e2 –> border-radius: 2px –> padding: 4px 12px –> Pressed button / toggled multibutton: box-shadow: inset 0 1px 1px rgba(0,0,0,0.15) –> Button font color: #373d3f –> Button :hover background-color: #f2f2f2, color: #222
  • In a button group only first and last button should have border-radius (first -> on the left, last -> on the right)

Issue Analytics

  • State:closed
  • Created 6 years ago
  • Comments:5 (5 by maintainers)

github_iconTop GitHub Comments

2reactions
peterszerzocommented, Sep 29, 2017

That makes sense, Michael - we’ll keep them out of composed.

That said, I still think button groups should be componentized in some form or fashion - as in they should be inside a wrapper component, which controls their spacings and border radii. Maybe we can make an exception to the rule of never importing a component inside another component and define a ButtonGroup one?

1reaction
micha-fcommented, Sep 29, 2017

@peterszerzo Copied the font-family definition for the code playground from here: https://github.com/atom/atom/blob/ac9cc728450f96096aeeb7d185420a06610b4df2/static/text-editor.less#L7 We don’t need to embed these fonts (and wouldn’t even be allowed to in the case of Menlo). These fonts should be available on Mac, Windows.

I think button groups are still very “primitive” components. I was thinking of composed components to be things like a complete “filter toolbar”. If that’s the case I believe that button groups - while composed of multiple buttons - are still closer to the button primitive (and could be described on the same showcase page) than a composed component like a filter toolbar.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Improve Gabel's Styling Gel Blue Regular Hold (32oz /2 lb ...
Amazon.com : Improve Gabel's Styling Gel Blue Regular Hold (32oz /2 lb) with pump authentic Gabel's Manufacturer Direct has Gabel's logo in black...
Read more >
Styling Gels & Lotions - Gabel's Cosmetics Inc.
Improve Styling Gels. Professional quality gels. Gabel's was one of the first manufacturers of gel products with over 30 years of experience.
Read more >
Gabel's Improve Styling Gel - Appleton Barber Supply
Gabel's Improve Styling Gel keeps hair smartly groomed all day. The gel amplifies the range of hair colors giving hair a healthy appearance....
Read more >
Gabel Improve Styling Gel 32 oz - Barber Salon Supply
Keeps hair smartly groomed all day. The clarity of the gel amplifies the widest range of hair colors giving hair a healthy appearance....
Read more >
Gabel's Improve Styling Gel - SD Barber Supply
Brands of Gabel's and Improve are trademarks by Gabel's Cosmetics Non Flaking & No ... Professionals: Salon and Barbershop Styling Gel for Hair...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found