question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

PageContents cannot be stacked

See original GitHub issue

In order to support the case below, we need two PageContents: image

Would require JSX along the lines of

<PageContent areas="main side">
    <Card title={`Job: ${data.name}`}>hi</Card>
    <Card title="Job Executions">I am not gay</Card>
  </PageContent>
<PageContent>
  <Card title="Bundle Events">Hi</Card>
</PageContent>

Except currently, PageContent assumes it will be the only PageContent and takes the entire height of its container, rendering the second PageContent below the fold, under the page, out of immediate sight.

Reproduction image

How can we solve this? @fabien0102 @peterszerzo

Issue Analytics

  • State:closed
  • Created 5 years ago
  • Comments:10 (10 by maintainers)

github_iconTop GitHub Comments

1reaction
peterszerzocommented, Jul 17, 2018

I agree that these are useful additions, but at the same time, having to do runtime warnings are a sign that the design will difficult to take in and maintain by a new developer, or even one seasoned with this codebase. This project has evolved in a manner that prefers compile-time safety and strict API’s, and the PageContent - PageArea direction is shaping up to go against that principle.

1reaction
TejasQcommented, Jul 17, 2018

I think the having one component per layout would make our users (in this case, me as a user) have to keep track of far too many moving parts.

Ultimately, I tried to do something the way I naturally expected it to work, and then a bug bit me. A bug with height 100%.

I think adherence to an API close to what I tried to do before I got bit makes the most sense, as it would be closer to what developers would normally expect; unless I develop with strange, unexpected patterns all the time.

To that effect, the PageArea approach makes more sense for me.

I already currently get a little lost in thinking “what should I use? PageContent? PageArea? 🤔”. I think adding another PageSomething into the mix would cause me pain as I use Operational components.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Stacking two parent flexbox containers on top of one another
I have used the property overflow: auto within .pageContent so scrolling shouldn't be an issue. Please find attached two image links: one of ......
Read more >
Corrupt PDF data and 'cannot find object in xref ...
Describe the bug (mandatory) Pdf object gets corrupt after trying to call insertPDF on top of an empty PDF and it also throws...
Read more >
Js error "Cannot read property 'stack' of undefined" from ...
Petar.petkovic moved this task from Backlog to Page contents issues on the CX-cxserver board. • ...
Read more >
Tridion Content Service returning no value for pageContent ...
I am facing issue in retrieving PageContent using content service. The content service returning results for other queries like(pages, ...
Read more >
Stack — cloudmesh_client 4.7.3 documentation
Stack ¶. Page Contents. Questions; About BDS. BDS Requirements; Using BDS ... BDS is not a Python library or program and therefore cannot...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found