question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

withBaseStyles should be assumed

See original GitHub issue

After implementing Operational UI in a number of UIs, withBaseStyles is being used extensively and seems to be a seemingly unnecessary piece of boilerplate. I propose we use base styles by default, and instead have a noBaseStyling prop or similar to allow for customization.

Thoughts?

Issue Analytics

  • State:closed
  • Created 5 years ago
  • Comments:6 (6 by maintainers)

github_iconTop GitHub Comments

1reaction
peterszerzocommented, May 28, 2018

Good points, fellas, let’s do it! It’ll be the first use of the deprecate HOC.

1reaction
fabien0102commented, May 28, 2018

As a new member in this project, I’m totally agree with @TejasQ , the basic bootstrap should be with a base style assumed. It’s a ui kit. And for customization, normally the theme props should do the job, no?

Read more comments on GitHub >

github_iconTop Results From Across the Web

SASS & CSS Formatting Guidelines - OpenLMIS
The contents of a varriables file should only include SASS variables, and output no CSS at anypoint. There is no assumed order in...
Read more >
stencil-tailwind-plugin - npm
While tailwindcss can be integrated into a Stencil build, this plugin aims to ... This guide assumes that a Stencil project has already...
Read more >
PostCSS Import Order with base styles not working #7049
once I move them to the imported file, the custom styles seem to be loaded before the tailwind styles, and break. i can...
Read more >
INSY 4315 REVIEW 2 Flashcards - Quizlet
A principle in which the overall page design starts with base styles that apply to all devices followed by style rules specific to...
Read more >
Using CSS custom properties to apply themes in JavaScript or ...
Include people who prefer to not use React but would still like to apply custom CSS properties in their theme work.
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found