ImportSpec error is not handle

We should not destructure the param here -> https://github.com/contiamo/restful-react/blob/master/src/scripts/import-open-api.ts#L213

This can cause this kind of error:

> restful-react import --file ../documentation/docs/reference/api/idp.swagger.json --output src/components/queries/idp.tsx --transformer schema-transformer.js

/Users/lucasroesler/Code/contiamo/idp/ui/node_modules/restful-react/lib/bin/restful-react-import.js:249
                var openapi = _a.openapi;
                                 ^

TypeError: Cannot read property 'openapi' of undefined
    at /Users/lucasroesler/Code/contiamo/idp/ui/node_modules/restful-react/lib/bin/restful-react-import.js:249:34
    at /Users/lucasroesler/Code/contiamo/idp/ui/node_modules/call-me-maybe/index.js:13:28
    at processTicksAndRejections (internal/process/next_tick.js:74:9)
    at process.runNextTicks [as _tickCallback] (internal/process/next_tick.js:5

If something we have an error, the program break before the actual error handler 😅

[dbtlr]

Any word on when this might be fixed? I’ve messed around with this a bit and found a potential solution, but I’m unsure of the downstream effects.

It seems like this is caused in the definition for swagger2openapi.d.ts, which needs to define data as optional for the convertObj callback to be valid.

swagger2openapi appears to use the call-me-maybe library, which follows gives the following response:

• If promise is fulfilled, then it is called with the result of the promise: cb(null, result)
• If promise is rejected, then it is called with the rejection error: cb(err)

The downstream effect that I can predict for this is that offending block needs to look more like this, as de-structuring no longer works when you fix the interface.

      swagger2openapi.convertObj(schema, {}, (err, data) => {
        if (err) {
          reject(err);
        } else {
          resolve(data?.openapi);
        }
      });

I don’t really like the way this looks and I’m not sure if there is any case where an undefined would be passed into resolve, however, in theory it would only happen on err anyway.

[fabien0102]

The real question is always, are yours specs really valid or the linter is failing? (I’m asking because we had the case previously, and appear that was a hole in the linter…)

Whatever, if you have a fix I will review your PR with pleasure before christmas, otherwise I will try to apply your solution on monday 😉