Lazy fetching of data will cause infinite loop / runaway effect

Describe the bug With a lazy useGet, placing the refetch within an effect will cause an infinite loop of fetches due to the refetch function getting regenerated on each render.

To Reproduce Steps to reproduce the behavior:

  const { refetch } = useGet(`/some-endpoint`, { lazy: true });

  React.useEffect(() => {
    refetch();
  }, [refetch]);

Expected behavior I believe that refetch should be memoised and should not fail the dependency check in an effect. SO that you can safely refetch data in an effect with the refetch function as a dependency.

[stereobooster]

I would expect refetch to be referentially transparent the same way as in:

const [isValid, setIsValid] = useState(true);

setIsValid is always the same reference. I would not consider React.useEffect(() => refetch(), [refetch]) as main use case, but referential transparency affects how react components re-render.

<ExpensiveComponent refetch={refetch}>

[johncblandii]

I started to wrap the component and have the reason why it was lazy loading in a different component and then let the query run as expected, but I couldn’t help fight to figure out a solution so we didn’t have to create extra components across the app.

For now I think calling it out on the readme would be great. I went there to see if there was a note about effects.