JDK 17 forbids access to internal com.sun packages

In ReflectionUtils, the following method violates the new security model in JDK 17:

public static void setTraversalEngine(Control control, Object engine) {
    try {
        Class<?> parentHelper = Class.forName("com.sun.javafx.scene.ParentHelper");
        Method method = parentHelper.getMethod("setTraversalEngine", Parent.class, engine.getClass());
        method.setAccessible(true);
        method.invoke(parentHelper, control, engine);
    } catch (IllegalAccessException | InvocationTargetException | NoSuchMethodException | ClassNotFoundException e) {
        throw new RuntimeException("Cannot set Traversal Engine");
    }
}

This prevents migration to JDK 17 for any JavaFX applications that use ControlsFX directly or indirectly (e.g., PreferencesFX).

FWIW, adding the export for scene traversal does not appear to resolve the issue:

def moduleSecurity = [
    "--add-opens=javafx.controls/javafx.scene.control=ALL-UNNAMED",
    "--add-opens=javafx.controls/javafx.scene.control.skin=ALL-UNNAMED",
    "--add-opens=javafx.graphics/javafx.scene.text=ALL-UNNAMED",
    "--add-opens=javafx.graphics/com.sun.javafx.css=ALL-UNNAMED",
    "--add-opens=javafx.graphics/com.sun.javafx.text=ALL-UNNAMED",
    "--add-exports=javafx.base/com.sun.javafx.event=ALL-UNNAMED",
    "--add-exports=javafx.graphics/com.sun.javafx.application=ALL-UNNAMED",
    "--add-exports=javafx.graphics/com.sun.javafx.geom=ALL-UNNAMED",
    "--add-exports=javafx.graphics/com.sun.javafx.scene.traversal=ALL-UNNAMED",
    "--add-exports=javafx.graphics/com.sun.javafx.text=ALL-UNNAMED",
]

[abhinayagarwal]

Hi @DaveJarvis ,

import com.sun.javafx.scene.control.skin.ComboBoxListViewSkin this shouldn’t exist in the latest ControlsFX code. You seem to be on the master branch which is still meant for JDK 8.

Please checkout jfx-13 branch and retry.

[DaveJarvis]

Please checkout jfx-13 branch and retry.

Smoke tested. These changes appear to work with JDK 17, thank you.