ListSelectionView broken in 8.40.15

In 8.40.15 the list selection view lists (target and source lists) seems to have stopped updating. Here is sample code demonstrating the problem:

package playing;

import java.util.ArrayList;
import java.util.Collections;
import java.util.List;

import org.controlsfx.control.ListSelectionView;

import javafx.application.Platform;
import javafx.collections.FXCollections;
import javafx.embed.swing.JFXPanel;
import javafx.geometry.Orientation;
import javafx.scene.control.ButtonType;
import javafx.scene.control.Dialog;
import javafx.util.Callback;

public class Playing
{
    private ListSelectionView<String> view;

    public Playing()
    {
        setup();
    }

    private void setup()
    {

        List<String> list = new ArrayList<>();
        list.add("A");
        list.add("B");
        list.add("C");
        list.add("D");
        view = new ListSelectionView<>();

        view.setOrientation(Orientation.HORIZONTAL);

        MyResultConverter resultConverter = new MyResultConverter();

        view.setTargetItems(FXCollections.observableList(list));

        Platform.runLater(() ->
        {
            Dialog<List<String>> fxDialog = new Dialog<>();
            fxDialog.setTitle("Select");
            fxDialog.getDialogPane().getButtonTypes().addAll(ButtonType.OK, ButtonType.CANCEL);
            fxDialog.getDialogPane().setContent(view);
            fxDialog.setResultConverter(resultConverter);
            fxDialog.setOnCloseRequest(e -> processResults(fxDialog.getResult()));
            fxDialog.show();
        });

    }

    public static void main(String[] args)
    {
        new JFXPanel();
        new Playing();
        try
        {
            Thread.sleep(30000);
        }
        catch (InterruptedException e)
        {
            Thread.currentThread().interrupt();
        }
    }

    /**
     * 
     * This callback is used by the dialog when the user hits the ok/cancel buttons
     * 
     * 
     */

    private class MyResultConverter implements Callback<ButtonType, List<String>>
    {
        @Override
        public List<String> call(ButtonType b)
        {
            if (b == ButtonType.OK)
            {
                System.out.println("Sources: ");
                view.getSourceItems().forEach(e -> System.out.print(e + "|"));
                return view.getTargetItems();
            }
            else
            {
                return Collections.emptyList();
            }
        }
    }

    private void processResults(List<String> list)
    {
        System.out.println("Result: ");
        list.stream().forEach(f -> System.out.println(f));
    }

}

When you run the dialog and modify the list, the result always print A B C D for the target list. Reverting back to 8.40.14 fixes it.

[abhinayagarwal]

@ViniciusSSilva Ah, my bad. I was checking the date of commit instead of the date of merge.

If someone wants to try out the latest version, we release snapshot versions for ControlsFX.

[ViniciusSSilva]

I am not sure why, but it seems both 8.40.15 and 11.0.0 does not have the fix in them. Can someone build from the source and check if it fixes the issue for them?

The 11.0.0 Release was done before #1117 bug-fix

I found a way to fix it using https://jitpack.io

add the arg: --add-exports=javafx.base/com.sun.javafx.runtime=ALL-UNNAMED

pom.xml changes (with maven):

...
<repositories>
     <repository>
          <id>jitpack.io</id>
          <url>https://jitpack.io</url>
     </repository>
</repositories>
...
<dependencies>
    ...
    <!-- ControlsFx Release Jul 08, 2019 -->
    <dependency>
        <groupId>com.github.abhinayagarwal.controlsfx</groupId>
        <artifactId>controlsfx</artifactId>
        <version>-cdad7beeb2-1</version>
    </dependency>
    ...
</dependencies>
...

Edit: It is also possible to use the version from the original repository

...
<repositories>
     <repository>
          <id>jitpack.io</id>
          <url>https://jitpack.io</url>
     </repository>
</repositories>
...
<dependencies>
    ...
    <!-- ControlsFx using origin/master as version -->
    <dependency>
        <groupId>com.github.controlsfx.controlsfx</groupId>
        <artifactId>controlsfx</artifactId>
        <version>-SNAPSHOT</version>
    </dependency>
    ...
</dependencies>
...