question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

header-full-stop?

See original GitHub issue

Expected Behavior

To be able to control full stops on my type-less, scope-less commit messages.

Current Behavior

I’m using commitlint with:

type-empty: [2, always]
scope-empty: [2, always]

According to the parser, I have an empty subject and what would usually be the subject, is understood by the parser to be the header. The header does not, at the moment, have a full stop setting. I’d love either header-full-stop or the parser recognising my subject correctly.

Affected packages

  • core
  • cli
  • prompt
  • config-angular

Steps to Reproduce (for bugs)

$ echo "Blah, blah, blah, blah, blah, blah." | commitlint

⧗   input: Blah, blah, blah, blah, blah, blah.
✔   found 0 problems, 0 warnings
.commitlintrc.yml <div class="highlight highlight-source-yaml">
  rules:
      header-max-length: [2, always, 50]
      header-min-length: [2, always, 1]
      body-max-line-length: [2, always, 72]
      body-min-length: [2, never]
      footer-max-line-length: [2, always, 72]
      footer-min-length: [2, never]
      subject-max-length: [2, always, 50]
      subject-min-length: [2, always, 1]
      scope-empty: [2, always]
      type-empty: [2, always]
      signed-off-by: [2, never]
  
</div>

Your Environment

Executable Version
commitlint --version 7.2.1
git --version 2.20.0
node --version 11.4.0

Issue Analytics

  • State:closed
  • Created 5 years ago
  • Reactions:2
  • Comments:12 (4 by maintainers)

github_iconTop GitHub Comments

5reactions
byCedriccommented, Jan 27, 2019

This has been released in 7.4.0! 😄 Let me know if it works fine, or if you encounter some issues with the new rules. Good luck!

1reaction
shreyasminochacommented, Jan 27, 2019

Thanks @byCedric!

Read more comments on GitHub >

github_iconTop Results From Across the Web

File details : Stencila
import parse from '@commitlint/parse'; import {headerFullStop} from './header-full-stop'; const messages = { with: `header.\n`, without: `header\n`, }; ...
Read more >
VSCode Conventional Commits - Visual Studio Marketplace
This extension helps you to fill in commit message according to Conventional Commits. Support commitlint configs. See Supported Commitlint Rules for details.
Read more >
commitlintrc.yml · cern · kubernetes / automation / charts / ceph ...
header-full-stop : [2, never, "."] 12. 13. # the subject cannot be empty. 14. subject-empty: [2, never]. 15. 16.
Read more >
@commitlint/rules@17.3.0 - jsDocs.io
'header-full-stop': any;. 'header-max-length': any;. 'header-min-length': any;. 'references-empty': any;. 'scope-case': any;.
Read more >
@commitlint/lint | Yarn - Package Manager
7.4.0 (2019-01-27). Bug Fixes. correction to need help link (#540 (fa6168a). Features. rules: create header-case and header-full-stop rules (#547 (4c36cbd) ...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found