Peer dependency warnings for @types/node
See original GitHub issueDepending on @commitlint/prompt or @commitlint/cli results in peer dependency warnings because the @types/node peer dependency of cosmiconfig-typescript-loader is not satisfied in @commitlint/load
Depending on @commitlint/prompt or @commitlint/cli should not result in any peer dependency warnings.
Depending on @commitlint/prompt or @commitlint/cli results in peer dependency warnings.
Affected packages
- cli
- core
- prompt
- config-angular
Possible Solution
Either expose @types/node as a peer dependency of @commitlint/load and then of @commitlint/cli and @commitlint/prompt, or add @types/node as a dependency of @commitlint/load.
I’d be happy to open a pull request for this, but am curious if there’s a preference as to how we resolve this (see above).
Steps to Reproduce (for bugs)
yarn init
yarn add @commitlint/cli
Context
Consolidate all JavaScript tooling into a single package https://github.com/hoverinc/hover-javascript/
Your Environment
Executable | Version |
---|---|
commitlint --version |
16.1.0 |
git --version |
1.33.0 |
node --version |
16.13.0 |
Issue Analytics
- State:
- Created 2 years ago
- Reactions:1
- Comments:6 (2 by maintainers)
Top GitHub Comments
Also, I use manypkg in my monorepos to keep dependencies aligned. I could open another PR to add that here but there a quite a few fixes it would make:
Got it, sounds good to me. Wanna give it a try?