Using Exclamation Mark for Breaking Change Confuses Parser

It appears that the conventional-commits-parser package doesn’t directly support the exclamation mark demarcation for noting a breaking change in a commit. Parsing the following commit measage:

chore!: drop node 8 support

Will yield a node with the following structure:

{
  type: null,
  scope: null,
  subject: null,
  merge: null,
  header: 'chore!: drop node 8 support',
  body: null,
  footer: null,
  notes: [],
  references: [],
  mentions: [],
  revert: null,
  hash: 'd0059c44727bd0562db42aedeed60713b698c264',
  breaking: false
}

A notable number of properties are left null in addition to not recognizing the ! indicating a breaking change. Support for ! is noted in the first item in the Specification https://www.conventionalcommits.org/en/v1.0.0/#specification.

[fhenz]

I solved this by supplying the parser function with the second options parameter. The options argument includes the fields headerPattern: /^(\w*)(?:\((.*)\))?!?: (.*)$/ and breakingHeaderPattern: /^(\w*)(?:\((.*)\))?!: (.*)$/ which seemingly solved the issue. I got these options from the “conventional-changelog-conventionalcommits” package, i.e.

const parser = require("conventional-commits-parser");
const spec = require("conventional-changelog-conventionalcommits");
...
const options = await spec();
const parsed = parser.sync(COMMIT, options.parserOpts);

resulting with COMMIT as chore!: drop node 8 support in this:

{
  type: 'chore',
  scope: null,
  subject: 'drop node 8 support',
  merge: null,
  header: 'chore!: drop node 8 support',
  body: null,
  footer: null,
  notes: [ { title: 'BREAKING CHANGE', text: 'drop node 8 support' } ],
  references: [],
  mentions: [],
  revert: null
}

[carloschneider]

Exclamation works perfectly with conventionalcommits preset:

npx conventional-recommended-bump --preset conventionalcommits