Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Fix windows tests (CI)

See original GitHub issue

Ok, not sure how I managed to miss this before. Tests with mocked git don’t work on windows due to mock-git and its dep mock-bin:

mock-bin creates an executable script with a shebang, which windows does not support, PR: (https://github.com/stevemao/mock-bin/pull/3)
mock-git doesn’t escape slashes, PR: (https://github.com/stevemao/mock-git/pull/3)
mock-git has no version range in its mock-bin dependency thus not getting the windows fix when it lands, issue: (https://github.com/stevemao/mock-git/issues/5)

Both of these packages will need updates to make the mock tests work. I have created PRs in the respective repos and verified that standard-version tests are fixed with them. This issue is to track the progress of those fixes.

Issue Analytics

State:
Created 7 years ago
Reactions:1
Comments:13 (13 by maintainers)

Top GitHub Comments

2reactions

bcoecommented, Jun 24, 2016

@Tapppi this agrees with what I was seeing, moving forward with fixes seems smart to me … I don’t think any of us want to spin up Windows VMs too frequently, having AppVeyor in place to stop regressions will be nice.

1reaction

bcoecommented, Jun 27, 2016

@Tapppi I’m pretty comfortable with removing Node 0.10 from Windows integration tests, if you don’t have time to dig into this further … gets us to a much better place than where we were.