Auto-away will change a user from Offline->Away, even if they explicitly set themselves offline

Hi JC and team,

First of all, thanks for this fantastic project.

We’re planning on deploying this and contributing and love the auto-away feature, but it seems to kick in even if the user has set themselves to “Offline”.

In other words: user wants to go offline, he/she changes his/her state to offline, but after X minutes the auto-away timer kicks in and puts them back online and set to “Away”.

It’s perhaps around here: if (this.auto_away > 0 && this.idle_seconds > this.auto_away && stat !== 'away' && stat !== 'xa') {

We understand there are limitations to “Offline”, including propagation, but our users really want it.

It seems that auto-away should only act on the user’s state if they are set to a normal “Online” state (not “Busy”, and not “Offline”); this is how AIM, ICQ, Google Talk/Hangouts and GAIM/Pidgin behave. Since there’s no xmpp “Offline” status, one option might be:

if (this.auto_away > 0 && this.idle_seconds > this.auto_away && stat == 'online') {

The only other feature we miss is the auto-open of a conversation on a page change/reload (this feature apparently went away in the last week or so), and ideally, notification sounds wouldn’t play if a conversation is in focus, or would be optional. We can open additional issues for those if you prefer.

Thanks again.

---

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

<bountysource-plugin>

[jcbrand]

I think I agree with you @theclifbar that auto_away shouldn’t apply to states besides online and chat (which is a special case of online).

However, I’d like to hear what @thierrytiti thinks about it, since he originally contributed this feature. @thierrytiti Can you comment on this?

About the other issues you mention @theclifbar, sounds like you are using the master branch. This is risky because it’s undergone lots of refactoring recently, is still under development and not considered stable. Chats should remain open across page loads and notifications shouldn’t play if the browser window is in focus. If these problems persist, you can create tickets for them, but I suggest you first double-check again with the latest code from master.

[jcbrand]

Fixed. The user’s status won’t be set to ‘away’ or ‘xa’ if they’re in the ‘dnd’ state.

There is no longer an ‘offline’ state.